[GitHub] [spark] bersprockets commented on a diff in pull request #41809: [SPARK-44251][SQL] Set nullable correctly on coalesced join key in full outer USING join

["bersprockets (via GitHub)" <gi...@apache.org>]

bersprockets commented on code in PR #41809:
URL: https://github.com/apache/spark/pull/41809#discussion_r1248350939


##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala:
##########
@@ -3364,7 +3364,12 @@ class Analyzer(override val catalogManager: CatalogManager) extends RuleExecutor
           leftKeys.map(_.withNullability(true)))
       case FullOuter =>
         // in full outer join, joinCols should be non-null if there is.

Review Comment:
   I think the comment is technically correct, although hard to decipher maybe. I think "if there is" means "if there is non-null joinCols on some side". The coalesce is there to make that comment true.
   
   I can make the comment more explicit.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org