You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/12/20 11:44:51 UTC
[GitHub] [cloudstack] GabrielBrascher opened a new pull request #5790: Add toggle button on the UI for list including elements in projects.
GabrielBrascher opened a new pull request #5790:
URL: https://github.com/apache/cloudstack/pull/5790
### Description
This PR allows listing elements that are in projects when in the Default view.
Nowadays, Admins cannot list in the UI many relevant data, unless entering in each of the projects, which can be humanly not feasible considering 10s or 100s of projects.
For example, one Admin cannot list all VMs, SSH keys, affinity groups, volumes, not even events that happen in a project in order to track all the events.
The UI tabs that are considered for this proposed PR are:
1. 'vm',
2. 'vmgroup',
3. 'ssh',
4. 'affinitygroup',
5. 'volume',
6. 'snapshot',
7. 'vmsnapshot',
8. 'guestnetwork',
9. 'vpc',
10. 'securitygroups',
11. 'publicip',
12. 'vpncustomergateway',
13. 'template',
14. 'iso',
15. 'event'
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [X] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [X] Major
- [ ] Minor
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [ ] Minor
- [ ] Trivial
### Screenshots (if appropriate):
#### VMs
#### Events
### How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
<!-- see how your change affects other areas of the code, etc. -->
- Build and run new UI
- Log in with admin account
- check tabs on default view
- check tabs on a project
- log with a "normal" user
- ensure that the user can list only elements in his own project
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5790: Add toggle button on the UI for list including elements in projects.
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5790:
URL: https://github.com/apache/cloudstack/pull/5790#issuecomment-1003043487
@GabrielBrascher a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5790: Add toggle button on the UI for list including elements in projects.
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5790:
URL: https://github.com/apache/cloudstack/pull/5790#issuecomment-1009971871
UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5790 (SL-JID-1002)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on pull request #5790: Add toggle button on the UI for list including elements in projects.
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #5790:
URL: https://github.com/apache/cloudstack/pull/5790#issuecomment-1010105879
> @sureshanaparti I've added a commit addressing your review:
> _Change switch button name from 'All Projects' to just 'Projects'_. [e1a94a9](https://github.com/apache/cloudstack/commit/e1a94a98e74886c705181322e43ee1e7dae3398a)
thanks @GabrielBrascher
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5790: Add toggle button on the UI for list including elements in projects.
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5790:
URL: https://github.com/apache/cloudstack/pull/5790#issuecomment-997852133
@GabrielBrascher a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GutoVeronezi commented on pull request #5790: Add toggle button on the UI for list including elements in projects.
Posted by GitBox <gi...@apache.org>.
GutoVeronezi commented on pull request #5790:
URL: https://github.com/apache/cloudstack/pull/5790#issuecomment-1002586037
@GabrielBrascher, understood.
Regarding to UX and in case of listing also project elements, I think we should add the project info into the list. Perhaps we should create an issue to address it in the future, as it will require more analysis and hard work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5790: Add toggle button on the UI for list including elements in projects.
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5790:
URL: https://github.com/apache/cloudstack/pull/5790#issuecomment-1003046620
UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5790 (SL-JID-953)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti edited a comment on pull request #5790: Add toggle button on the UI for list including elements in projects.
Posted by GitBox <gi...@apache.org>.
sureshanaparti edited a comment on pull request #5790:
URL: https://github.com/apache/cloudstack/pull/5790#issuecomment-1008885860
Verified changes. @GabrielBrascher Can you change the toggle button label to 'Projects' from 'All Projects' (Should be ok? as the toggle indicates that project elements are being considered).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti merged pull request #5790: Add toggle button on the UI for list including elements in projects.
Posted by GitBox <gi...@apache.org>.
sureshanaparti merged pull request #5790:
URL: https://github.com/apache/cloudstack/pull/5790
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GabrielBrascher commented on pull request #5790: Add toggle button on the UI for list including elements in projects.
Posted by GitBox <gi...@apache.org>.
GabrielBrascher commented on pull request #5790:
URL: https://github.com/apache/cloudstack/pull/5790#issuecomment-1009963818
@sureshanaparti I've added a commit addressing your review:
_Change switch button name from 'All Projects' to just 'Projects'_. e1a94a9
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GabrielBrascher commented on pull request #5790: Add toggle button on the UI for list including elements in projects.
Posted by GitBox <gi...@apache.org>.
GabrielBrascher commented on pull request #5790:
URL: https://github.com/apache/cloudstack/pull/5790#issuecomment-1003032297
@rohityadavcloud making it into 4.16.1.0 sounds good! Changed the base branch from main to 4.16.
> 1. maybe add an account column in user resources such as VM, volumes, networks etc (as those belonging to a project will list the name of the project as account?)
Regarding the account column, it might be interesting indeed.
> 2. should this be a global switch on the top, besides the project selector dropdown? (or left of the translation button)
That's a good point of discussion.
The idea behind my proposal was to make it only on the elements that can be listed according to the project id, therefore it would not be "global". Personally, I think that it fits well with the same approach as the metrics switch button; it is placed only on resources that can have their metrics listed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GabrielBrascher commented on pull request #5790: Add toggle button on the UI for list including elements in projects.
Posted by GitBox <gi...@apache.org>.
GabrielBrascher commented on pull request #5790:
URL: https://github.com/apache/cloudstack/pull/5790#issuecomment-997851791
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GabrielBrascher edited a comment on pull request #5790: Add toggle button on the UI for list including elements in projects.
Posted by GitBox <gi...@apache.org>.
GabrielBrascher edited a comment on pull request #5790:
URL: https://github.com/apache/cloudstack/pull/5790#issuecomment-1002580063
Thanks for the review, @GutoVeronezi.
It is possible to check which project a VM is by getting into the respective VM UI tab.
For example, this is one of the VMs I had for this test:
Same goes with volumes:
However, not all the listed elements have a project id in their details, one example is when listing Events in the UI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GabrielBrascher commented on pull request #5790: Add toggle button on the UI for list including elements in projects.
Posted by GitBox <gi...@apache.org>.
GabrielBrascher commented on pull request #5790:
URL: https://github.com/apache/cloudstack/pull/5790#issuecomment-1003043180
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5790: Add toggle button on the UI for list including elements in projects.
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5790:
URL: https://github.com/apache/cloudstack/pull/5790#issuecomment-1007876975
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5790: Add toggle button on the UI for list including elements in projects.
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5790:
URL: https://github.com/apache/cloudstack/pull/5790#issuecomment-1007876975
@rohityadavcloud a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GabrielBrascher commented on pull request #5790: Add toggle button on the UI for list including elements in projects.
Posted by GitBox <gi...@apache.org>.
GabrielBrascher commented on pull request #5790:
URL: https://github.com/apache/cloudstack/pull/5790#issuecomment-1009761813
@sureshanaparti thanks for the testing and review.
Sure, I can change the label to just Projects.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5790: Add toggle button on the UI for list including elements in projects.
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5790:
URL: https://github.com/apache/cloudstack/pull/5790#issuecomment-1009964484
@GabrielBrascher a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GabrielBrascher commented on pull request #5790: Add toggle button on the UI for list including elements in projects.
Posted by GitBox <gi...@apache.org>.
GabrielBrascher commented on pull request #5790:
URL: https://github.com/apache/cloudstack/pull/5790#issuecomment-1002580063
Thanks for the review, @GutoVeronezi.
It is possible to check which project a VM is by getting into the respective VM UI tab.
For example, this is one of the VMs I had for this test:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GabrielBrascher commented on pull request #5790: Add toggle button on the UI for list including elements in projects.
Posted by GitBox <gi...@apache.org>.
GabrielBrascher commented on pull request #5790:
URL: https://github.com/apache/cloudstack/pull/5790#issuecomment-1009963976
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5790: Add toggle button on the UI for list including elements in projects.
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5790:
URL: https://github.com/apache/cloudstack/pull/5790#issuecomment-997854826
UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5790 (SL-JID-919)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GutoVeronezi commented on pull request #5790: Add toggle button on the UI for list including elements in projects.
Posted by GitBox <gi...@apache.org>.
GutoVeronezi commented on pull request #5790:
URL: https://github.com/apache/cloudstack/pull/5790#issuecomment-1002569429
@GabrielBrascher, thanks for the PR!
CLGTM, I'm just wondering if, when also listing elements that are in projects, users will be able to distinguish which project each resource belongs to.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on pull request #5790: Add toggle button on the UI for list including elements in projects.
Posted by GitBox <gi...@apache.org>.
rohityadavcloud commented on pull request #5790:
URL: https://github.com/apache/cloudstack/pull/5790#issuecomment-1002953477
LGTM - should this be on 4.16 @GabrielBrascher since it's a minor UI change and (some) backend APIs already supports listing with projectid=-1?
@GabrielBrascher suggestions:
1. maybe add an account column in user resources such as VM, volumes, networks etc (as those belonging to a project will list the name of the project as account?)
2. should this be a global switch on the top, besides the project selector dropdown? (or left of the translation button)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on pull request #5790: Add toggle button on the UI for list including elements in projects.
Posted by GitBox <gi...@apache.org>.
rohityadavcloud commented on pull request #5790:
URL: https://github.com/apache/cloudstack/pull/5790#issuecomment-1007876830
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5790: Add toggle button on the UI for list including elements in projects.
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5790:
URL: https://github.com/apache/cloudstack/pull/5790#issuecomment-1007894209
UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5790 (SL-JID-984)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on pull request #5790: Add toggle button on the UI for list including elements in projects.
Posted by GitBox <gi...@apache.org>.
rohityadavcloud commented on pull request #5790:
URL: https://github.com/apache/cloudstack/pull/5790#issuecomment-1007876830
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on pull request #5790: Add toggle button on the UI for list including elements in projects.
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #5790:
URL: https://github.com/apache/cloudstack/pull/5790#issuecomment-1008885860
Verified changes. @GabrielBrascher Can you change the toggle button label to 'Projects' from 'All Projects'?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org