[jira] [Updated] (HIVE-3204) Windows: Fix the unit tests which contains “!” commands (Unix shell commands)

["Kanna Karanam (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/HIVE-3204?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kanna Karanam updated HIVE-3204:
--------------------------------

    Attachment: HIVE-3204.1.patch.txt

Attached the patch.

Replaced all “!<cmd> with DFS commands to run unit tests on Unix as well as Windows.

Known Issue: Didn’t fix the ddltime.q unit test failure on windows yet. It has a “!sleep 1” command and I couldn’t invoke a simple java method to sleep for 1 sec. I will address this as a separate Jira as it requires more changes. 
SELECT java_method("java.lang.Thread", "sleep", 1000) FROM src LIMIT 1;

                
> Windows: Fix the unit tests which contains “!<cmd>” commands (Unix shell commands)
> ----------------------------------------------------------------------------------
>
>                 Key: HIVE-3204
>                 URL: https://issues.apache.org/jira/browse/HIVE-3204
>             Project: Hive
>          Issue Type: Sub-task
>          Components: Tests, Windows
>    Affects Versions: 0.10.0
>            Reporter: Kanna Karanam
>            Assignee: Kanna Karanam
>             Fix For: 0.10.0
>
>         Attachments: HIVE-3204.1.patch.txt
>
>
> Possible solution 1: (Preferred one)
> !<Unix cmd | Windows cmd> => Keeping the same syntax. Hive uses Java runtime to launch the shell command  so any attempt to run windows commands on Unix will fail and vice versa.
> To deal with unit tests. Unix commands in each .q file will be modified as shown below. I will filter out the !commands which can’t be run on the current .
> Original entry in.q file:
> !rm -rf ../build/ql/test/data/exports/exim_department;
> It will be replaced with the following entries.
> UNIX::!rm -rf ../build/ql/test/data/exports/exim_department;
> WINDOWS::!del ../build/ql/test/data/exports/exim_department
> Possible solution 2:
> Provide a Shell UDF library(JAVA Based code)to support platform independent shell functionality
> Cons – 
> 1) Difficult to provide full shell functionality
> 2) Takes long time
> 3) Difficult to manage

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira