You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ofbiz.apache.org by "Jacques Le Roux (JIRA)" <ji...@apache.org> on 2008/02/20 15:01:43 UTC
[jira] Commented: (OFBIZ-1663) POS: All payment types allow
change to be made
[ https://issues.apache.org/jira/browse/OFBIZ-1663?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12570693#action_12570693 ]
Jacques Le Roux commented on OFBIZ-1663:
----------------------------------------
Yes I agree,
This is weird, we should not take into account any amount given when processing with a credit card. Note that actually if you give any amount it's ok. BTW it's the same with any payment mean.
In case of multiple payments type sales credit should be only allowed at the last payment method. I tried but I got
2008-02-20 14:57:32,796 (Thread-1742) [ Log4jLoggerWriter.java:67 :INFO ] [POS @ pos-1 TX:11258] - is Aggregated Item(GZ-1001)
2008-02-20 14:57:36,953 (Thread-1744) [ Log4jLoggerWriter.java:67 :INFO ] [POS @ pos-1 TX:11258] - is Aggregated Item(GZ-1001)
2008-02-20 14:57:36,953 (Thread-1744) [ Log4jLoggerWriter.java:67 :INFO ] [POS @ pos-1 TX:11258] - process sale
2008-02-20 14:57:36,968 (Thread-1744) [ ShoppingCart.java:4609:INFO ] Compare [Pm: null / PmType: CASH / Amt: 10.0 / Ref: null!null] to [Pm: 10004 / PmType: CREDIT_CARD / Amt: null / Ref: null!null]
2008-02-20 14:57:36,968 (Thread-1744) [ ShoppingCart.java:4609:INFO ] Compare [Pm: 10004 / PmType: CREDIT_CARD / Amt: 15.989999999999998 / Ref: null!null] to [Pm: 10004 / PmType: CREDIT_CARD / Amt: null
/ Ref: null!null]
2008-02-20 14:57:36,968 (Thread-1744) [ ShoppingCart.java:1454:INFO ] Returned existing PaymentInfo - Pm: 10004 / PmType: CREDIT_CARD / Amt: 15.989999999999998 / Ref: null!null
2008-02-20 14:57:36,984 (Thread-1744) [ PosButton.java:125:ERROR]
---- exception report ----------------------------------------------------------
Button invocation exception - ALT.payFinish
Exception: org.ofbiz.pos.config.ButtonEventConfig$ButtonEventException
Message: null
---- stack trace ---------------------------------------------------------------
org.ofbiz.pos.config.ButtonEventConfig$ButtonEventException
org.ofbiz.pos.config.ButtonEventConfig.invoke(ButtonEventConfig.java:216)
org.ofbiz.pos.config.ButtonEventConfig.invokeButtonEvent(ButtonEventConfig.java:105)
org.ofbiz.pos.component.PosButton$1.construct(PosButton.java:121)
net.xoetrope.xui.helper.SwingWorker$2.run(Unknown Source)
java.lang.Thread.run(Thread.java:595)
java.lang.reflect.InvocationTargetException
sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
java.lang.reflect.Method.invoke(Method.java:585)
org.ofbiz.pos.config.ButtonEventConfig.invoke(ButtonEventConfig.java:208)
org.ofbiz.pos.config.ButtonEventConfig.invokeButtonEvent(ButtonEventConfig.java:105)
org.ofbiz.pos.component.PosButton$1.construct(PosButton.java:121)
net.xoetrope.xui.helper.SwingWorker$2.run(Unknown Source)
java.lang.Thread.run(Thread.java:595)
Caused by: org.ofbiz.base.util.GeneralRuntimeException: Split Payment Preference per Ship Group does not yet support multiple Payment Methods
org.ofbiz.order.shoppingcart.ShoppingCart$CartPaymentInfo.makeOrderPaymentInfos(ShoppingCart.java:4527)
org.ofbiz.order.shoppingcart.ShoppingCart.makeAllOrderPaymentInfos(ShoppingCart.java:3588)
org.ofbiz.order.shoppingcart.ShoppingCart.makeCartMap(ShoppingCart.java:3825)
org.ofbiz.order.shoppingcart.CheckOutHelper.createOrder(CheckOutHelper.java:572)
org.ofbiz.order.shoppingcart.CheckOutHelper.createOrder(CheckOutHelper.java:545)
org.ofbiz.pos.PosTransaction.processSale(PosTransaction.java:763)
org.ofbiz.pos.event.PaymentEvents.processSale(PaymentEvents.java:306)
... 9 more
--------------------------------------------------------------------------------
I then tried with credit card 1st and cash last, then cash + check and got the same error. Not sure yet if it's a configuration error or something else. And I have no time to investigate further for now. I will see mater and if necessary will open a new Jira issue for this.
> POS: All payment types allow change to be made
> ------------------------------------------------
>
> Key: OFBIZ-1663
> URL: https://issues.apache.org/jira/browse/OFBIZ-1663
> Project: OFBiz
> Issue Type: Improvement
> Components: specialpurpose/pos
> Affects Versions: Release Branch 4.0
> Reporter: Chris Lombardi
> Priority: Minor
>
> I fat-fingered the amount of the transaction when I was testing credit card processing and was surprised to see the POS making change for a credit card transaction.
> I would imagine change would be allowed if and only if the amount of change is less than the amount of cash given. This would apply for both cash sales and multiple payment type sales.
> Does anyone have any international scenarios that would not follow this rule?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.