You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@lenya.apache.org by an...@apache.org on 2005/08/30 00:34:49 UTC

svn commit: r264647 - in /lenya/trunk/src/java/org/apache/lenya: cms/usecase/AbstractUsecase.java cms/usecase/DocumentUsecase.java workflow/impl/WorkflowManagerImpl.java

Author: andreas
Date: Mon Aug 29 15:34:35 2005
New Revision: 264647

URL: http://svn.apache.org/viewcvs?rev=264647&view=rev
Log:
Performance: added workflow schema cache

Modified:
    lenya/trunk/src/java/org/apache/lenya/cms/usecase/AbstractUsecase.java
    lenya/trunk/src/java/org/apache/lenya/cms/usecase/DocumentUsecase.java
    lenya/trunk/src/java/org/apache/lenya/workflow/impl/WorkflowManagerImpl.java

Modified: lenya/trunk/src/java/org/apache/lenya/cms/usecase/AbstractUsecase.java
URL: http://svn.apache.org/viewcvs/lenya/trunk/src/java/org/apache/lenya/cms/usecase/AbstractUsecase.java?rev=264647&r1=264646&r2=264647&view=diff
==============================================================================
--- lenya/trunk/src/java/org/apache/lenya/cms/usecase/AbstractUsecase.java (original)
+++ lenya/trunk/src/java/org/apache/lenya/cms/usecase/AbstractUsecase.java Mon Aug 29 15:34:35 2005
@@ -342,7 +342,9 @@
      * @see org.apache.lenya.cms.usecase.Usecase#getParameter(java.lang.String)
      */
     public Object getParameter(String name) {
-        initializeParametersIfNotDone();
+        if (!this.parameters.containsKey(name)) {
+            initializeParametersIfNotDone();
+        }
         return this.parameters.get(name);
     }
 

Modified: lenya/trunk/src/java/org/apache/lenya/cms/usecase/DocumentUsecase.java
URL: http://svn.apache.org/viewcvs/lenya/trunk/src/java/org/apache/lenya/cms/usecase/DocumentUsecase.java?rev=264647&r1=264646&r2=264647&view=diff
==============================================================================
--- lenya/trunk/src/java/org/apache/lenya/cms/usecase/DocumentUsecase.java (original)
+++ lenya/trunk/src/java/org/apache/lenya/cms/usecase/DocumentUsecase.java Mon Aug 29 15:34:35 2005
@@ -59,7 +59,8 @@
     public void setSourceURL(String url) {
         try {
             if (getDocumentIdentityMap().isDocument(url)) {
-                setParameter(DOCUMENT, getDocumentIdentityMap().getFromURL(url));
+                Document document = getDocumentIdentityMap().getFromURL(url);
+                setParameter(DOCUMENT, document);
             }
         } catch (Exception e) {
             throw new RuntimeException(e);

Modified: lenya/trunk/src/java/org/apache/lenya/workflow/impl/WorkflowManagerImpl.java
URL: http://svn.apache.org/viewcvs/lenya/trunk/src/java/org/apache/lenya/workflow/impl/WorkflowManagerImpl.java?rev=264647&r1=264646&r2=264647&view=diff
==============================================================================
--- lenya/trunk/src/java/org/apache/lenya/workflow/impl/WorkflowManagerImpl.java (original)
+++ lenya/trunk/src/java/org/apache/lenya/workflow/impl/WorkflowManagerImpl.java Mon Aug 29 15:34:35 2005
@@ -16,6 +16,9 @@
  */
 package org.apache.lenya.workflow.impl;
 
+import java.util.HashMap;
+import java.util.Map;
+
 import org.apache.avalon.excalibur.pool.Poolable;
 import org.apache.avalon.framework.logger.AbstractLogEnabled;
 import org.apache.avalon.framework.service.ServiceException;
@@ -38,6 +41,8 @@
 public class WorkflowManagerImpl extends AbstractLogEnabled implements WorkflowManager,
         Serviceable, Poolable {
 
+    private Map uri2workflow = new HashMap();
+
     /**
      * @see org.apache.lenya.workflow.WorkflowManager#invoke(org.apache.lenya.workflow.Workflowable,
      *      java.lang.String, boolean)
@@ -104,9 +109,13 @@
             String uri = workflowable.getWorkflowSchemaURI();
             getLogger().debug("Workflow URI: " + uri);
             if (uri != null) {
-                Document document = SourceUtil.readDOM(uri, this.manager);
-                WorkflowBuilder builder = new WorkflowBuilder(getLogger());
-                workflow = builder.buildWorkflow(uri, document);
+                workflow = (WorkflowImpl) this.uri2workflow.get(uri);
+                if (workflow == null) {
+                    Document document = SourceUtil.readDOM(uri, this.manager);
+                    WorkflowBuilder builder = new WorkflowBuilder(getLogger());
+                    workflow = builder.buildWorkflow(uri, document);
+                    this.uri2workflow.put(uri, workflow);
+                }
             }
         } catch (final Exception e) {
             throw new WorkflowException(e);



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@lenya.apache.org
For additional commands, e-mail: commits-help@lenya.apache.org