You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Carl Steinbach <ca...@cloudera.com> on 2011/12/05 22:15:13 UTC
Re: Review Request: HIVE-2362. HiveConf properties not appearing in the
output of 'set' or 'set -v'
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2960/
-----------------------------------------------------------
(Updated 2011-12-05 21:15:13.146776)
Review request for hive and John Sichi.
Changes
-------
Updated diff including a new testcase.
Summary
-------
Fix for HIVE-2362.
This addresses bug HIVE-2362.
https://issues.apache.org/jira/browse/HIVE-2362
Diffs (updated)
-----
eclipse-templates/.classpath b020907
common/src/test/resources/hive-site.xml PRE-CREATION
conf/hive-default.xml 53eca0e
common/src/test/org/apache/hadoop/hive/conf/TestHiveConf.java PRE-CREATION
build-common.xml 1d162de
common/build.xml 432eba5
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java d9b6fd5
Diff: https://reviews.apache.org/r/2960/diff
Testing
-------
Thanks,
Carl
Re: Review Request: HIVE-2362. HiveConf properties not appearing in the
output of 'set' or 'set -v'
Posted by Carl Steinbach <ca...@cloudera.com>.
> On 2011-12-05 23:39:18, John Sichi wrote:
> > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java, line 776
> > <https://reviews.apache.org/r/2960/diff/2/?file=61977#file61977line776>
> >
> > Carl, there is an addResource overload which takes an InputStream. Can't we use that plus ByteArrayOutputStream to avoid having to create a temporary file?
I tried this approach originally, but o.a.h.conf.Configuration.addResource(InputStream) is broken. Anything you add using this method gets added to a list which is reloaded on every subsequent call to addResource, which results in an unexpected EOF exception on the first reload.
- Carl
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2960/#review3648
-----------------------------------------------------------
On 2011-12-05 21:15:13, Carl Steinbach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/2960/
> -----------------------------------------------------------
>
> (Updated 2011-12-05 21:15:13)
>
>
> Review request for hive and John Sichi.
>
>
> Summary
> -------
>
> Fix for HIVE-2362.
>
>
> This addresses bug HIVE-2362.
> https://issues.apache.org/jira/browse/HIVE-2362
>
>
> Diffs
> -----
>
> eclipse-templates/.classpath b020907
> common/src/test/resources/hive-site.xml PRE-CREATION
> conf/hive-default.xml 53eca0e
> common/src/test/org/apache/hadoop/hive/conf/TestHiveConf.java PRE-CREATION
> build-common.xml 1d162de
> common/build.xml 432eba5
> common/src/java/org/apache/hadoop/hive/conf/HiveConf.java d9b6fd5
>
> Diff: https://reviews.apache.org/r/2960/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Carl
>
>
Re: Review Request: HIVE-2362. HiveConf properties not appearing in the
output of 'set' or 'set -v'
Posted by John Sichi <js...@fb.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2960/#review3648
-----------------------------------------------------------
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java
<https://reviews.apache.org/r/2960/#comment8142>
Carl, there is an addResource overload which takes an InputStream. Can't we use that plus ByteArrayOutputStream to avoid having to create a temporary file?
- John
On 2011-12-05 21:15:13, Carl Steinbach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/2960/
> -----------------------------------------------------------
>
> (Updated 2011-12-05 21:15:13)
>
>
> Review request for hive and John Sichi.
>
>
> Summary
> -------
>
> Fix for HIVE-2362.
>
>
> This addresses bug HIVE-2362.
> https://issues.apache.org/jira/browse/HIVE-2362
>
>
> Diffs
> -----
>
> eclipse-templates/.classpath b020907
> common/src/test/resources/hive-site.xml PRE-CREATION
> conf/hive-default.xml 53eca0e
> common/src/test/org/apache/hadoop/hive/conf/TestHiveConf.java PRE-CREATION
> build-common.xml 1d162de
> common/build.xml 432eba5
> common/src/java/org/apache/hadoop/hive/conf/HiveConf.java d9b6fd5
>
> Diff: https://reviews.apache.org/r/2960/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Carl
>
>