You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/04/24 06:15:37 UTC
[GitHub] [shardingsphere] TaoZhiMLND opened a new pull request #5300: add OracleXAConnectionWrapper.
TaoZhiMLND opened a new pull request #5300:
URL: https://github.com/apache/shardingsphere/pull/5300
Fixes #4297 .
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-io commented on pull request #5300: add OracleXAConnectionWrapper.
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #5300:
URL: https://github.com/apache/shardingsphere/pull/5300#issuecomment-618832142
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/5300?src=pr&el=h1) Report
> Merging [#5300](https://codecov.io/gh/apache/shardingsphere/pull/5300?src=pr&el=desc) into [master](https://codecov.io/gh/apache/shardingsphere/commit/022ab36713d4c6a13170ffd4b1edfe4a6ae2593c&el=desc) will **decrease** coverage by `0.01%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/shardingsphere/pull/5300?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5300 +/- ##
============================================
- Coverage 53.71% 53.69% -0.02%
Complexity 411 411
============================================
Files 1162 1163 +1
Lines 20782 20789 +7
Branches 3765 3766 +1
============================================
Hits 11163 11163
- Misses 8891 8898 +7
Partials 728 728
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/5300?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...saction/xa/jta/connection/XAConnectionFactory.java](https://codecov.io/gh/apache/shardingsphere/pull/5300/diff?src=pr&el=tree#diff-c2hhcmRpbmctdHJhbnNhY3Rpb24vc2hhcmRpbmctdHJhbnNhY3Rpb24tMnBjL3NoYXJkaW5nLXRyYW5zYWN0aW9uLXhhL3NoYXJkaW5nLXRyYW5zYWN0aW9uLXhhLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3RyYW5zYWN0aW9uL3hhL2p0YS9jb25uZWN0aW9uL1hBQ29ubmVjdGlvbkZhY3RvcnkuamF2YQ==) | `71.42% <0.00%> (-11.91%)` | `0.00 <0.00> (ø)` | |
| [.../connection/dialect/OracleXAConnectionWrapper.java](https://codecov.io/gh/apache/shardingsphere/pull/5300/diff?src=pr&el=tree#diff-c2hhcmRpbmctdHJhbnNhY3Rpb24vc2hhcmRpbmctdHJhbnNhY3Rpb24tMnBjL3NoYXJkaW5nLXRyYW5zYWN0aW9uLXhhL3NoYXJkaW5nLXRyYW5zYWN0aW9uLXhhLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3RyYW5zYWN0aW9uL3hhL2p0YS9jb25uZWN0aW9uL2RpYWxlY3QvT3JhY2xlWEFDb25uZWN0aW9uV3JhcHBlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/5300?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/5300?src=pr&el=footer). Last update [022ab36...9185915](https://codecov.io/gh/apache/shardingsphere/pull/5300?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] cherrylzhao commented on pull request #5300: add OracleXAConnectionWrapper.
Posted by GitBox <gi...@apache.org>.
cherrylzhao commented on pull request #5300:
URL: https://github.com/apache/shardingsphere/pull/5300#issuecomment-618846918
nice job !
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] coveralls commented on pull request #5300: add OracleXAConnectionWrapper.
Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #5300:
URL: https://github.com/apache/shardingsphere/pull/5300#issuecomment-618833245
## Pull Request Test Coverage Report for [Build 11230](https://coveralls.io/builds/30307426)
* **0** of **7** **(0.0%)** changed or added relevant lines in **2** files are covered.
* No unchanged relevant lines lost coverage.
* Overall coverage decreased (**-0.02%**) to **57.261%**
---
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
| :-----|--------------|--------|---: |
| [sharding-transaction/sharding-transaction-2pc/sharding-transaction-xa/sharding-transaction-xa-core/src/main/java/org/apache/shardingsphere/transaction/xa/jta/connection/XAConnectionFactory.java](https://coveralls.io/builds/30307426/source?filename=sharding-transaction%2Fsharding-transaction-2pc%2Fsharding-transaction-xa%2Fsharding-transaction-xa-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Ftransaction%2Fxa%2Fjta%2Fconnection%2FXAConnectionFactory.java#L58) | 0 | 1 | 0.0%
| [sharding-transaction/sharding-transaction-2pc/sharding-transaction-xa/sharding-transaction-xa-core/src/main/java/org/apache/shardingsphere/transaction/xa/jta/connection/dialect/OracleXAConnectionWrapper.java](https://coveralls.io/builds/30307426/source?filename=sharding-transaction%2Fsharding-transaction-2pc%2Fsharding-transaction-xa%2Fsharding-transaction-xa-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Ftransaction%2Fxa%2Fjta%2Fconnection%2Fdialect%2FOracleXAConnectionWrapper.java#L34) | 0 | 6 | 0.0%
<!-- | **Total:** | **0** | **7** | **0.0%** | -->
| Totals | [](https://coveralls.io/builds/30307426) |
| :-- | --: |
| Change from base [Build 11229](https://coveralls.io/builds/30305543): | -0.02% |
| Covered Lines: | 11904 |
| Relevant Lines: | 20789 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org