You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/01/15 21:31:54 UTC
[GitHub] [superset] codecov-io edited a comment on pull request #12535: fix(dashboard): uncaught error when loading dashboards with slices associated with deleted dataset
codecov-io edited a comment on pull request #12535:
URL: https://github.com/apache/superset/pull/12535#issuecomment-760639369
# [Codecov](https://codecov.io/gh/apache/superset/pull/12535?src=pr&el=h1) Report
> Merging [#12535](https://codecov.io/gh/apache/superset/pull/12535?src=pr&el=desc) (3e7b8d1) into [master](https://codecov.io/gh/apache/superset/commit/8adc8b886623f2413944dd7d68151185e3004d8d?el=desc) (8adc8b8) will **decrease** coverage by `0.43%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/superset/pull/12535?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12535 +/- ##
==========================================
- Coverage 63.79% 63.36% -0.44%
==========================================
Files 932 486 -446
Lines 45213 29956 -15257
Branches 4335 0 -4335
==========================================
- Hits 28843 18981 -9862
+ Misses 16193 10975 -5218
+ Partials 177 0 -177
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `?` | |
| python | `63.36% <ø> (-0.82%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12535?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/models/dashboard.py](https://codecov.io/gh/apache/superset/pull/12535/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2Rhc2hib2FyZC5weQ==) | `75.50% <ø> (ø)` | |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/12535/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/examples/energy.py](https://codecov.io/gh/apache/superset/pull/12535/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvZW5lcmd5LnB5) | `27.50% <0.00%> (-72.50%)` | :arrow_down: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/superset/pull/12535/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `30.98% <0.00%> (-69.02%)` | :arrow_down: |
| [superset/datasets/commands/importers/v1/utils.py](https://codecov.io/gh/apache/superset/pull/12535/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvY29tbWFuZHMvaW1wb3J0ZXJzL3YxL3V0aWxzLnB5) | `55.55% <0.00%> (-37.31%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/12535/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.61% <0.00%> (-29.62%)` | :arrow_down: |
| [superset/examples/birth\_names.py](https://codecov.io/gh/apache/superset/pull/12535/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `73.19% <0.00%> (-25.65%)` | :arrow_down: |
| [superset/datasets/commands/export.py](https://codecov.io/gh/apache/superset/pull/12535/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvY29tbWFuZHMvZXhwb3J0LnB5) | `78.72% <0.00%> (-15.40%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/12535/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `70.56% <0.00%> (-11.85%)` | :arrow_down: |
| [superset/examples/helpers.py](https://codecov.io/gh/apache/superset/pull/12535/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvaGVscGVycy5weQ==) | `85.36% <0.00%> (-9.76%)` | :arrow_down: |
| ... and [588 more](https://codecov.io/gh/apache/superset/pull/12535/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12535?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12535?src=pr&el=footer). Last update [8adc8b8...3e7b8d1](https://codecov.io/gh/apache/superset/pull/12535?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org