You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@tez.apache.org by "Aggarwal-Raghav (via GitHub)" <gi...@apache.org> on 2026/07/19 08:33:16 UTC
[PR] TEZ-4740: Remove method parameter from ProfileServlet [tez]
Aggarwal-Raghav opened a new pull request, #525:
URL: https://github.com/apache/tez/pull/525
This essentially reverts TEZ-4487
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@tez.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] TEZ-4740: Fix typo in ProfileServlet javadoc for method profiling [tez]
Posted by "abstractdog (via GitHub)" <gi...@apache.org>.
abstractdog merged PR #525:
URL: https://github.com/apache/tez/pull/525
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@tez.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] TEZ-4740: Remove method parameter from ProfileServlet [tez]
Posted by "Aggarwal-Raghav (via GitHub)" <gi...@apache.org>.
Aggarwal-Raghav commented on PR #525:
URL: https://github.com/apache/tez/pull/525#issuecomment-5021109870
> > fix the comment typo from -m to -e flag
>
> thanks @Aggarwal-Raghav for investigating this: I was worried that maybe async profiler dropped the support of profiling methods, however, if it works with the `-e`, we can simply fix the typo definitely! the goal is to be very clear about the fact that in newer async profiler versions, method profiling is possible via the `-e` option feel free to rename Jira accordingly
i think older also it was `-e` since 2.0 https://github.com/async-profiler/async-profiler/blob/v2.0/README.md#java-method-profiling
So, now I'll rename this ticket to update the javadoc only and update the path to only support for 4.4 and drop support for 3.x?
https://github.com/apache/tez/blob/b9d8c0f37b3c3fdc17d2c007297b3b559bd468a4/tez-common/src/main/java/org/apache/tez/common/web/ProfileServlet.java#L306-L314
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@tez.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] TEZ-4740: Fix typo in ProfileServlet javadoc for method profiling [tez]
Posted by "tez-yetus (via GitHub)" <gi...@apache.org>.
tez-yetus commented on PR #525:
URL: https://github.com/apache/tez/pull/525#issuecomment-5022107894
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|:----:|----------:|--------:|:--------:|:-------:|
| +0 :ok: | reexec | 0m 7s | | Docker mode activated. |
|||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | | No case conflicting files found. |
| +0 :ok: | detsecrets | 0m 0s | | detect-secrets was not available. |
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain any @author tags. |
| -1 :x: | test4tests | 0m 0s | | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
|||| _ master Compile Tests _ |
| +1 :green_heart: | mvninstall | 3m 6s | | master passed |
| +1 :green_heart: | compile | 2m 29s | | master passed |
| +1 :green_heart: | checkstyle | 0m 21s | | master passed |
| +1 :green_heart: | javadoc | 0m 19s | | master passed |
| +0 :ok: | spotbugs | 0m 35s | | tez-common in master has 13 extant spotbugs warnings. |
|||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 2m 10s | | the patch passed |
| +1 :green_heart: | codespell | 0m 50s | | No new issues. |
| +1 :green_heart: | compile | 2m 29s | | the patch passed |
| +1 :green_heart: | javac | 2m 29s | | the patch passed |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks issues. |
| +1 :green_heart: | checkstyle | 0m 17s | | the patch passed |
| +1 :green_heart: | javadoc | 0m 19s | | the patch passed |
| +1 :green_heart: | spotbugs | 0m 40s | | the patch passed |
|||| _ Other Tests _ |
| +1 :green_heart: | unit | 60m 23s | | root in the patch passed. |
| +1 :green_heart: | asflicense | 0m 22s | | The patch does not generate ASF License warnings. |
| | | 75m 28s | | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.55 ServerAPI=1.55 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-525/2/artifact/out/Dockerfile |
| Optional Tests | dupname compile unit asflicense javac javadoc spotbugs checkstyle codespell detsecrets |
| uname | Linux b09575a92cc4 5.15.0-181-generic #191-Ubuntu SMP Fri May 22 19:09:02 UTC 2026 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | tez-personality.sh |
| git revision | master / b9d8c0f37b3c3fdc17d2c007297b3b559bd468a4 |
| Default Java | Eclipse Adoptium-21.0.11+10-LTS |
| Test Results | https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-525/2/testReport/ |
| Max. process+thread count | 1497 (vs. ulimit of 5500) |
| modules | C: tez-common U: tez-common |
| Console output | https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-525/2/console |
| versions | git=2.43.0 maven=3.9.15 spotbugs=4.9.3 codespell=2.4.1 |
| Powered by | Apache Yetus 0.15.1 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@tez.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] TEZ-4740: Fix typo in ProfileServlet javadoc for method profiling [tez]
Posted by "Aggarwal-Raghav (via GitHub)" <gi...@apache.org>.
Aggarwal-Raghav commented on PR #525:
URL: https://github.com/apache/tez/pull/525#issuecomment-5021540190
@abstractdog , if we want to support for method and cpu/alloc/lock profiling, need to change the profileServlet class and test it. As async-profiler supportes multiple events in comma-separated way `-e cpu,alloc,lock` but tez profileServlet is not supporting event + method case.
let me know if we want to test that as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@tez.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] TEZ-4740: Fix typo in ProfileServlet javadoc for method profiling [tez]
Posted by "abstractdog (via GitHub)" <gi...@apache.org>.
abstractdog commented on PR #525:
URL: https://github.com/apache/tez/pull/525#issuecomment-5024070881
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@tez.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] TEZ-4740: Remove method parameter from ProfileServlet [tez]
Posted by "tez-yetus (via GitHub)" <gi...@apache.org>.
tez-yetus commented on PR #525:
URL: https://github.com/apache/tez/pull/525#issuecomment-5015267564
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|:----:|----------:|--------:|:--------:|:-------:|
| +0 :ok: | reexec | 2m 22s | | Docker mode activated. |
|||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | | No case conflicting files found. |
| +0 :ok: | detsecrets | 0m 0s | | detect-secrets was not available. |
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain any @author tags. |
| -1 :x: | test4tests | 0m 0s | | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
|||| _ master Compile Tests _ |
| +1 :green_heart: | mvninstall | 3m 2s | | master passed |
| +1 :green_heart: | compile | 2m 35s | | master passed |
| +1 :green_heart: | checkstyle | 0m 21s | | master passed |
| +1 :green_heart: | javadoc | 0m 19s | | master passed |
| +0 :ok: | spotbugs | 0m 35s | | tez-common in master has 13 extant spotbugs warnings. |
|||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 2m 11s | | the patch passed |
| +1 :green_heart: | codespell | 0m 48s | | No new issues. |
| +1 :green_heart: | compile | 2m 34s | | the patch passed |
| +1 :green_heart: | javac | 2m 34s | | the patch passed |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks issues. |
| +1 :green_heart: | checkstyle | 0m 16s | | the patch passed |
| +1 :green_heart: | javadoc | 0m 18s | | the patch passed |
| +1 :green_heart: | spotbugs | 0m 39s | | the patch passed |
|||| _ Other Tests _ |
| -1 :x: | unit | 60m 4s | [/patch-unit-root.txt](https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-525/1/artifact/out/patch-unit-root.txt) | root in the patch passed. |
| +1 :green_heart: | asflicense | 0m 20s | | The patch does not generate ASF License warnings. |
| | | 77m 28s | | |
| Reason | Tests |
|-------:|:------|
| Failed junit tests | tez.history.TestHistoryParser |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.55 ServerAPI=1.55 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-525/1/artifact/out/Dockerfile |
| Optional Tests | dupname compile unit asflicense javac javadoc spotbugs checkstyle codespell detsecrets |
| uname | Linux 33b347b5c041 5.15.0-181-generic #191-Ubuntu SMP Fri May 22 19:09:02 UTC 2026 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | tez-personality.sh |
| git revision | master / b9d8c0f37b3c3fdc17d2c007297b3b559bd468a4 |
| Default Java | Eclipse Adoptium-21.0.11+10-LTS |
| Test Results | https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-525/1/testReport/ |
| Max. process+thread count | 1565 (vs. ulimit of 5500) |
| modules | C: tez-common U: tez-common |
| Console output | https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-525/1/console |
| versions | git=2.43.0 maven=3.9.15 spotbugs=4.9.3 codespell=2.4.1 |
| Powered by | Apache Yetus 0.15.1 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@tez.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] TEZ-4740: Remove method parameter from ProfileServlet [tez]
Posted by "abstractdog (via GitHub)" <gi...@apache.org>.
abstractdog commented on PR #525:
URL: https://github.com/apache/tez/pull/525#issuecomment-5020935413
> fix the comment typo from -m to -e flag
thanks @Aggarwal-Raghav for investigating this: I was worried that maybe async profiler dropped the support of profiling methods, however, if it works with the `-e`, we can simply fix the typo definitely! the goal is to be very clear about the fact that in newer async profiler versions, method profiling is possible via the `-e` option
feel free to rename Jira accordingly
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@tez.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] TEZ-4740: Remove method parameter from ProfileServlet [tez]
Posted by "abstractdog (via GitHub)" <gi...@apache.org>.
abstractdog commented on PR #525:
URL: https://github.com/apache/tez/pull/525#issuecomment-5021160948
> > > fix the comment typo from -m to -e flag
> >
> >
> > thanks @Aggarwal-Raghav for investigating this: I was worried that maybe async profiler dropped the support of profiling methods, however, if it works with the `-e`, we can simply fix the typo definitely! the goal is to be very clear about the fact that in newer async profiler versions, method profiling is possible via the `-e` option feel free to rename Jira accordingly
>
> i think older also it was `-e` since 2.0 https://github.com/async-profiler/async-profiler/blob/v2.0/README.md#java-method-profiling
>
> So, now I'll rename this ticket to update the javadoc only and update the path to only support for 4.4 and drop support for 3.x?
>
> https://github.com/apache/tez/blob/b9d8c0f37b3c3fdc17d2c007297b3b559bd468a4/tez-common/src/main/java/org/apache/tez/common/web/ProfileServlet.java#L306-L314
I think dropping profile 3.x support is another thing to discuss, I'm fine with not doing it now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@tez.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] TEZ-4740: Remove method parameter from ProfileServlet [tez]
Posted by "Aggarwal-Raghav (via GitHub)" <gi...@apache.org>.
Aggarwal-Raghav commented on PR #525:
URL: https://github.com/apache/tez/pull/525#issuecomment-5021164260
> > > > fix the comment typo from -m to -e flag
> > >
> > >
> > > thanks @Aggarwal-Raghav for investigating this: I was worried that maybe async profiler dropped the support of profiling methods, however, if it works with the `-e`, we can simply fix the typo definitely! the goal is to be very clear about the fact that in newer async profiler versions, method profiling is possible via the `-e` option feel free to rename Jira accordingly
> >
> >
> > i think older also it was `-e` since 2.0 https://github.com/async-profiler/async-profiler/blob/v2.0/README.md#java-method-profiling
> > So, now I'll rename this ticket to update the javadoc only and update the path to only support for 4.4 and drop support for 3.x?
> > https://github.com/apache/tez/blob/b9d8c0f37b3c3fdc17d2c007297b3b559bd468a4/tez-common/src/main/java/org/apache/tez/common/web/ProfileServlet.java#L306-L314
>
> I think dropping profile 3.x support is another thing to discuss, I'm fine with not doing it now
ACK
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@tez.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] TEZ-4740: Remove method parameter from ProfileServlet [tez]
Posted by "Aggarwal-Raghav (via GitHub)" <gi...@apache.org>.
Aggarwal-Raghav commented on PR #525:
URL: https://github.com/apache/tez/pull/525#issuecomment-5021486424
So final behaviour:
`http://localhost:50000/prof?event=cpu&duration=10`
**FOR CPU:**
<img width="1512" height="198" alt="Screenshot 2026-07-20 at 4 20 10 PM" src="https://github.com/user-attachments/assets/f7470586-4050-4ee9-8826-ca94c4747794" />
<img width="1505" height="658" alt="Screenshot 2026-07-20 at 4 20 46 PM" src="https://github.com/user-attachments/assets/acbd2a29-0eef-486d-9c9d-b7489672f0e5" />
**FOR METHOD:**
<img width="1511" height="236" alt="Screenshot 2026-07-20 at 4 24 03 PM" src="https://github.com/user-attachments/assets/08bb0acc-0e82-49a7-bb27-9027bb44bf6a" />
<img width="1511" height="313" alt="Screenshot 2026-07-20 at 4 24 14 PM" src="https://github.com/user-attachments/assets/2783d484-5c20-4961-bbb6-7d91cf85d612" />
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@tez.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] TEZ-4740: Remove method parameter from ProfileServlet [tez]
Posted by "Aggarwal-Raghav (via GitHub)" <gi...@apache.org>.
Aggarwal-Raghav commented on PR #525:
URL: https://github.com/apache/tez/pull/525#issuecomment-5015411114
@abstractdog , I verified that the `?method=` parameter was maping to the `-e` flag and successfully generates FlameGraphs for that method in the async-profiler 4.4 i.e. latest
As per async-profiler readme:
https://github.com/async-profiler/async-profiler/blob/master/docs/ProfilingModes.md#java-method-profiling
> -e ClassName.methodName option instruments the given Java method in order to record all invocations of this method with the stack traces.
**I have a question, do we want to stop this method level profiling if yes then this PR is correct otherwise,
Do you want to keep the feature, cancel TEZ-4740, and just fix the comment typo from -m to -e flag?**
**BEFORE:**
<img width="1512" height="263" alt="Screenshot 2026-07-19 at 3 27 53 PM" src="https://github.com/user-attachments/assets/ad3473cf-01d3-432c-adb1-1e3944ab1ada" />
<img width="1512" height="247" alt="Screenshot 2026-07-19 at 3 28 13 PM" src="https://github.com/user-attachments/assets/f84efbc4-cc0b-441c-a25e-004c18306f94" />
**AFTER:**
<img width="1507" height="170" alt="Screenshot 2026-07-19 at 3 58 00 PM" src="https://github.com/user-attachments/assets/2f4e8cd0-6a10-48c4-978a-094d77a9d164" />
<img width="793" height="328" alt="Screenshot 2026-07-19 at 4 00 16 PM" src="https://github.com/user-attachments/assets/5c4226e3-7413-4fb3-9850-b79770ad4c12" />
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@tez.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org