You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "vanshb03 (via GitHub)" <gi...@apache.org> on 2025/04/23 11:32:35 UTC
[PR] AVRO: Support UUID logical type on string fields in Avro schema [iceberg]
vanshb03 opened a new pull request, #12877:
URL: https://github.com/apache/iceberg/pull/12877
Addresses #12862
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] AVRO: Support UUID logical type on string fields in Avro schema [iceberg]
Posted by "vanshb03 (via GitHub)" <gi...@apache.org>.
vanshb03 commented on code in PR #12877:
URL: https://github.com/apache/iceberg/pull/12877#discussion_r2056819304
##########
core/src/main/java/org/apache/iceberg/avro/SchemaToType.java:
##########
@@ -208,6 +208,8 @@ public Type logicalType(Schema primitive, LogicalType logical) {
} else if (LogicalTypes.uuid().getName().equals(name)) {
Review Comment:
Wasn't this making the first UUID check more explicit by comparing names instead of just invoking `LogicalTypes.uuid()`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] AVRO: Support UUID logical type on string fields in Avro schema [iceberg]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #12877:
URL: https://github.com/apache/iceberg/pull/12877#issuecomment-3002220074
This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@iceberg.apache.org list. Thank you for your contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] AVRO: Support UUID logical type on string fields in Avro schema [iceberg]
Posted by "raphaelauv (via GitHub)" <gi...@apache.org>.
raphaelauv commented on code in PR #12877:
URL: https://github.com/apache/iceberg/pull/12877#discussion_r2056802939
##########
core/src/main/java/org/apache/iceberg/avro/SchemaToType.java:
##########
@@ -208,6 +208,8 @@ public Type logicalType(Schema primitive, LogicalType logical) {
} else if (LogicalTypes.uuid().getName().equals(name)) {
Review Comment:
what about replace
`else if (LogicalTypes.uuid().getName().equals(name)) {`
by
`else if (logical instanceof LogicalTypes.Uuid) { `
?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] AVRO: Support UUID logical type on string fields in Avro schema [iceberg]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #12877:
URL: https://github.com/apache/iceberg/pull/12877#issuecomment-3029789878
This pull request has been closed due to lack of activity. This is not a judgement on the merit of the PR in any way. It is just a way of keeping the PR queue manageable. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] AVRO: Support UUID logical type on string fields in Avro schema [iceberg]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #12877:
URL: https://github.com/apache/iceberg/pull/12877#issuecomment-2907520282
This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@iceberg.apache.org list. Thank you for your contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] AVRO: Support UUID logical type on string fields in Avro schema [iceberg]
Posted by "vanshb03 (via GitHub)" <gi...@apache.org>.
vanshb03 commented on PR #12877:
URL: https://github.com/apache/iceberg/pull/12877#issuecomment-2907520623
Bumping branch for review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] AVRO: Support UUID logical type on string fields in Avro schema [iceberg]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #12877: AVRO: Support UUID logical type on string fields in Avro schema
URL: https://github.com/apache/iceberg/pull/12877
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org