You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@drill.apache.org by Hanifi Gunes <ha...@gmail.com> on 2015/05/11 08:37:08 UTC

Review Request 34030: DRILL-3022: ensure sequential shutdown of drillbits

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34030/
-----------------------------------------------------------

Review request for drill, Chris Westin and Venki Korukanti.


Repository: drill-git


Description
-------

DRILL-3022: ensure sequential shutdown of drillbits


Diffs
-----

  exec/java-exec/src/main/java/org/apache/drill/exec/server/Drillbit.java 531253e4245a1a4f50216359ed5591f0f1804b31 

Diff: https://reviews.apache.org/r/34030/diff/


Testing
-------

unit


Thanks,

Hanifi Gunes

Re: Review Request 34030: DRILL-3022: ensure sequential shutdown of drillbits

Posted by Hanifi Gunes <ha...@gmail.com>.


> On May 11, 2015, 6:40 a.m., Chris Westin wrote:
> > exec/java-exec/src/main/java/org/apache/drill/exec/server/Drillbit.java, line 329
> > <https://reviews.apache.org/r/34030/diff/1/?file=955135#file955135line329>
> >
> >     I also added this block comment before the synchronized block in my version:
> >     
> >             /*
> >              * We can avoid metrics deregistration concurrency issues by only closing
> >              * one drillbit at a time. To enforce that, we synchronize on a convenient
> >              * singleton object.
> >              */

Sorry just committed this. Can you rebase and add your comment too?


- Hanifi


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34030/#review83203
-----------------------------------------------------------


On May 11, 2015, 6:37 a.m., Hanifi Gunes wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34030/
> -----------------------------------------------------------
> 
> (Updated May 11, 2015, 6:37 a.m.)
> 
> 
> Review request for drill, Chris Westin and Venki Korukanti.
> 
> 
> Repository: drill-git
> 
> 
> Description
> -------
> 
> DRILL-3022: ensure sequential shutdown of drillbits
> 
> 
> Diffs
> -----
> 
>   exec/java-exec/src/main/java/org/apache/drill/exec/server/Drillbit.java 531253e4245a1a4f50216359ed5591f0f1804b31 
> 
> Diff: https://reviews.apache.org/r/34030/diff/
> 
> 
> Testing
> -------
> 
> unit
> 
> 
> Thanks,
> 
> Hanifi Gunes
> 
>

Re: Review Request 34030: DRILL-3022: ensure sequential shutdown of drillbits

Posted by Chris Westin <ch...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34030/#review83203
-----------------------------------------------------------


With the addition of a comment explaining what's going on here, ship it (non-binding).


exec/java-exec/src/main/java/org/apache/drill/exec/server/Drillbit.java
<https://reviews.apache.org/r/34030/#comment134106>

    I also added this block comment before the synchronized block in my version:
    
            /*
             * We can avoid metrics deregistration concurrency issues by only closing
             * one drillbit at a time. To enforce that, we synchronize on a convenient
             * singleton object.
             */


- Chris Westin


On May 10, 2015, 11:37 p.m., Hanifi Gunes wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34030/
> -----------------------------------------------------------
> 
> (Updated May 10, 2015, 11:37 p.m.)
> 
> 
> Review request for drill, Chris Westin and Venki Korukanti.
> 
> 
> Repository: drill-git
> 
> 
> Description
> -------
> 
> DRILL-3022: ensure sequential shutdown of drillbits
> 
> 
> Diffs
> -----
> 
>   exec/java-exec/src/main/java/org/apache/drill/exec/server/Drillbit.java 531253e4245a1a4f50216359ed5591f0f1804b31 
> 
> Diff: https://reviews.apache.org/r/34030/diff/
> 
> 
> Testing
> -------
> 
> unit
> 
> 
> Thanks,
> 
> Hanifi Gunes
> 
>

Re: Review Request 34030: DRILL-3022: ensure sequential shutdown of drillbits

Posted by Venki Korukanti <ve...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34030/#review83204
-----------------------------------------------------------

Ship it!


Ship It!

- Venki Korukanti


On May 10, 2015, 11:37 p.m., Hanifi Gunes wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34030/
> -----------------------------------------------------------
> 
> (Updated May 10, 2015, 11:37 p.m.)
> 
> 
> Review request for drill, Chris Westin and Venki Korukanti.
> 
> 
> Repository: drill-git
> 
> 
> Description
> -------
> 
> DRILL-3022: ensure sequential shutdown of drillbits
> 
> 
> Diffs
> -----
> 
>   exec/java-exec/src/main/java/org/apache/drill/exec/server/Drillbit.java 531253e4245a1a4f50216359ed5591f0f1804b31 
> 
> Diff: https://reviews.apache.org/r/34030/diff/
> 
> 
> Testing
> -------
> 
> unit
> 
> 
> Thanks,
> 
> Hanifi Gunes
> 
>

Re: Review Request 34030: DRILL-3022: ensure sequential shutdown of drillbits

Posted by Chris Westin <ch...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34030/#review83206
-----------------------------------------------------------



exec/java-exec/src/main/java/org/apache/drill/exec/server/Drillbit.java
<https://reviews.apache.org/r/34030/#comment134108>

    Sure, I'll keep my version, and it'll go in with my current work.


- Chris Westin


On May 10, 2015, 11:37 p.m., Hanifi Gunes wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34030/
> -----------------------------------------------------------
> 
> (Updated May 10, 2015, 11:37 p.m.)
> 
> 
> Review request for drill, Chris Westin and Venki Korukanti.
> 
> 
> Repository: drill-git
> 
> 
> Description
> -------
> 
> DRILL-3022: ensure sequential shutdown of drillbits
> 
> 
> Diffs
> -----
> 
>   exec/java-exec/src/main/java/org/apache/drill/exec/server/Drillbit.java 531253e4245a1a4f50216359ed5591f0f1804b31 
> 
> Diff: https://reviews.apache.org/r/34030/diff/
> 
> 
> Testing
> -------
> 
> unit
> 
> 
> Thanks,
> 
> Hanifi Gunes
> 
>