You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/11/30 10:56:24 UTC

[GitHub] [flink] XComp opened a new pull request, #21428: [FLINK-30138][runtime][test] Increases timeout to essentially wait forever for an expected Exception to be thrown

XComp opened a new pull request, #21428:
URL: https://github.com/apache/flink/pull/21428

   ## What is the purpose of the change
   
   The tests run the cleanup logic in a separate thread. The assert requires a timeout which was not necessarily long enough for the exception to be caught.
   
   ## Brief change log
   
   * Increases the timeout to a day to simulate "waiting forever"
   
   ## Verifying this change
   
   This change is a trivial rework.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
     - The serializers: no
     - The runtime per-record code paths (performance sensitive): no
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
     - The S3 file system connector: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? no
     - If yes, how is the feature documented? not applicable


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] XComp merged pull request #21428: [FLINK-30138][runtime][test] Increases timeout to essentially wait forever for an expected Exception to be thrown

Posted by GitBox <gi...@apache.org>.
XComp merged PR #21428:
URL: https://github.com/apache/flink/pull/21428


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #21428: [FLINK-30138][runtime][test] Increases timeout to essentially wait forever for an expected Exception to be thrown

Posted by GitBox <gi...@apache.org>.
flinkbot commented on PR #21428:
URL: https://github.com/apache/flink/pull/21428#issuecomment-1331975142

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "9851856df58193890cef4e7121412bf6f25870a5",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "9851856df58193890cef4e7121412bf6f25870a5",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 9851856df58193890cef4e7121412bf6f25870a5 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] XComp commented on pull request #21428: [FLINK-30138][runtime][test] Increases timeout to essentially wait forever for an expected Exception to be thrown

Posted by GitBox <gi...@apache.org>.
XComp commented on PR #21428:
URL: https://github.com/apache/flink/pull/21428#issuecomment-1331986138

   I force-pushed a change where I got rid of the timeout entirely and use `assertThatThrownBy`, instead.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org