[jira] [Commented] (FLINK-2551) Fix Several Bugs in Input/Output Formats

["Nick Dimiduk (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-2551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15092711#comment-15092711 ] 

Nick Dimiduk commented on FLINK-2551:
-------------------------------------

bq. The Streaming API does not call {{setInputType}} if a format implements {{InputTypeConfigurable}}.

I just ran into this in a test while using {{LocalCollectionOutputFormat}} in combination with {{DataStream.write}}. The {{write}} method wraps the provided {{OutputFormat}} in a {{FileSinkFunctionByMillis}}, which does not implement {{InputTypeConfigurable}} and does not proxy calls to the delegate {{format}} instance.

[~aljoscha] are you planning to pick up this ticket? Maybe it can be broken into subtasks that can be committed as folks find time?

> Fix Several Bugs in Input/Output Formats
> ----------------------------------------
>
>                 Key: FLINK-2551
>                 URL: https://issues.apache.org/jira/browse/FLINK-2551
>             Project: Flink
>          Issue Type: Bug
>    Affects Versions: 0.9
>            Reporter: Aljoscha Krettek
>            Assignee: Aljoscha Krettek
>
> This is a collection of several things that are wrong (or possibly problematic) in the handling of Input/Output formats.
> The things I have so far:
> - TypeSerializerInputFormat was changed to take a TypeInformation instead of a TypeSerialzer. The javadoc is not updated, however
> - This lead to another bug: When the serializer is created from the TypeInformation it is not given the correct ExecutionConfig from the ExecutionEnvironment and thus custom serializers don't work. (This one, I broke)
> - In BinaryOutputFormat some fields are not declared transient even though they should be
> - The Streaming API does not call {{setInputType}} if a format implements {{InputTypeConfigurable}}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)