You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by "kfaraz (via GitHub)" <gi...@apache.org> on 2023/03/16 12:37:24 UTC

[GitHub] [druid] kfaraz opened a new pull request, #13942: Enable round-robin segment assignment and batch segment allocation by default

kfaraz opened a new pull request, #13942:
URL: https://github.com/apache/druid/pull/13942

   ### Description
   
   1. Round-robin segment assignment greatly speeds up coordinator run times and is hugely beneficial to all clusters.
   2. Batch segment allocation works extremely well when you have multiple concurrent realtime tasks for a single supervisor. It has not been seen to adversely affect other cases either, such as those with multiple supervisors with a handful of concurrent tasks each.
   
   We have had both of these flags turned on in our prod clusters and they have been working successfully.
   
   ### Changes:
   - Set `useRoundRobinSegmentAssignment` in coordinator dynamic config to `true` by default
   - Set `batchSegmentAllocation` in `TaskLockConfig` (used in Overlord runtime properties) to `true` by default
   
   #### Release note
   Turn on round-robin segment assignment by default. This can be turned off (not advised) by setting `useRoundRobinSegmentAssignment=false` in the coordinator dynamic config.
   Turn on batch segment allocation by default. You may turn this off by setting `druid.overlord.tasklock.batchSegmentAllocation=false` in the Overlord runtime properties only in the following cases.
   - `task/action/run/time` metric values increase significantly after an upgrade to this version
   - there are failures in batch allocation
   
   <hr>
   
   ##### Key changed/added classes in this PR
    * `MyFoo`
    * `OurBar`
    * `TheirBaz`
   
   <hr>
   
   This PR has:
   
   - [ ] been self-reviewed.
      - [ ] using the [concurrency checklist](https://github.com/apache/druid/blob/master/dev/code-review/concurrency.md) (Remove this item if the PR doesn't have any relation to concurrency.)
   - [ ] added documentation for new or modified features or behaviors.
   - [ ] a release note entry in the PR description.
   - [ ] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
   - [ ] added or updated version, license, or notice information in [licenses.yaml](https://github.com/apache/druid/blob/master/dev/license.md)
   - [ ] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
   - [ ] added unit tests or modified existing tests to cover new code paths, ensuring the threshold for [code coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md) is met.
   - [ ] added integration tests.
   - [ ] been tested in a test Druid cluster.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org

[GitHub] [druid] kfaraz commented on pull request #13942: Enable round-robin segment assignment and batch segment allocation by default

Posted by "kfaraz (via GitHub)" <gi...@apache.org>.
kfaraz commented on PR #13942:
URL: https://github.com/apache/druid/pull/13942#issuecomment-1478848188

   Thanks for the review, @abhishekagarwal87 !


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org

[GitHub] [druid] kfaraz merged pull request #13942: Enable round-robin segment assignment and batch segment allocation by default

Posted by "kfaraz (via GitHub)" <gi...@apache.org>.
kfaraz merged PR #13942:
URL: https://github.com/apache/druid/pull/13942


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org