You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by GitBox <gi...@apache.org> on 2020/03/12 08:47:18 UTC

[GitHub] [couchdb] rnewson opened a new pull request #2657: Set cookie domain when DELETE'ing

rnewson opened a new pull request #2657: Set cookie domain when DELETE'ing
URL: https://github.com/apache/couchdb/pull/2657
 
 
   ## Overview
   
   We failed to set the domain attribute when deleting the session cookie, resulting in the creation of an empty cookie without a domain attribute instead.
   
   ## Testing recommendations
   
   Follow the steps in the related case and note that the cookie is deleted with this patch.
   
   ## Related Issues or Pull Requests
   
   https://github.com/apache/couchdb/issues/2655
   
   ## Checklist
   
   - [x] Code is written and works correctly
   - [x] Changes are covered by tests
   - [ ] Any new configurable parameters are documented in `rel/overlay/etc/default.ini`
   - [ ] A PR for documentation changes has been made in https://github.com/apache/couchdb-documentation
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [couchdb] rnewson merged pull request #2657: Set cookie domain when DELETE'ing

Posted by GitBox <gi...@apache.org>.
rnewson merged pull request #2657: Set cookie domain when DELETE'ing
URL: https://github.com/apache/couchdb/pull/2657
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services