You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by "liunaijie (via GitHub)" <gi...@apache.org> on 2024/11/05 03:14:39 UTC

[I] [Improvement][Parameter Parser] Improvement the parameter parser [dolphinscheduler]

liunaijie opened a new issue, #16765:
URL: https://github.com/apache/dolphinscheduler/issues/16765

   ### Search before asking
   
   - [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar feature requirement.
   
   
   ### Description
   
   Now we support 2 kinds of parameter definition.
   1. System variable
   use `${}`
   2. Time related variable
   use `$[]`, and in this variable we also support data calculate, like `$[add_months(yyyyMMdd,N)]`
   
   But now we can't support the case that we need concat a fixed value with a dynamic value.
   like  `/tmp/${system.workflow.instance.id}`
   
   Do we need improve the parser to support more flexible definition.
   like `/tmp/$[yyyy-MM-dd]/${system.workflow.instance.id}`
   
   
   I has write some simple code and test, the design is like this.
   
   ![image](https://github.com/user-attachments/assets/4939958d-1774-4af5-8082-d6abb8cd7494)
   
   
   
   
   ### Are you willing to submit a PR?
   
   - [X] Yes I am willing to submit a PR!
   
   ### Code of Conduct
   
   - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] [Improvement][Parameter Parser] Improvement the parameter parser [dolphinscheduler]

Posted by "liunaijie (via GitHub)" <gi...@apache.org>.
liunaijie closed issue #16765: [Improvement][Parameter Parser] Improvement the parameter parser
URL: https://github.com/apache/dolphinscheduler/issues/16765


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] [Improvement][Parameter Parser] Improvement the parameter parser [dolphinscheduler]

Posted by "SbloodyS (via GitHub)" <gi...@apache.org>.
SbloodyS commented on issue #16765:
URL: https://github.com/apache/dolphinscheduler/issues/16765#issuecomment-2456164649

   Please create an DSIP first. @liunaijie 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] [Improvement][Parameter Parser] Improvement the parameter parser [dolphinscheduler]

Posted by "liunaijie (via GitHub)" <gi...@apache.org>.
liunaijie commented on issue #16765:
URL: https://github.com/apache/dolphinscheduler/issues/16765#issuecomment-2456177502

   close as created DSIP https://github.com/apache/dolphinscheduler/issues/16766


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org