[GitHub] [pulsar] nicoloboschi commented on a diff in pull request #16423: [fix][functions] Fix netty.DnsResolverUtil compat issue on JDK9+ for the function Runtimes

[GitBox <gi...@apache.org>]

nicoloboschi commented on code in PR #16423:
URL: https://github.com/apache/pulsar/pull/16423#discussion_r915551317


##########
pulsar-functions/runtime/src/main/java/org/apache/pulsar/functions/runtime/RuntimeUtils.java:
##########
@@ -320,6 +320,11 @@ public static List<String> getCmd(InstanceConfig instanceConfig,
 
             args.add("-Dio.netty.tryReflectionSetAccessible=true");
 
+            // Needed for netty.DnsResolverUtil on JDK9+
+            if (!System.getProperty("java.version").startsWith("1.")) {
+                args.add("--add-opens java.base/sun.net=ALL-UNNAMED");

Review Comment:
   `java.base/sun.net`should be enough for Pulsar client since it's the same configuration used in pulsar-client CLI tool.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org