You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by Jun Rao <ju...@gmail.com> on 2013/10/16 19:19:59 UTC

Review Request 14676: Patch for KAFKA-1091

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14676/
-----------------------------------------------------------

Review request for kafka.


Bugs: KAFKA-1091
    https://issues.apache.org/jira/browse/KAFKA-1091


Repository: kafka


Description
-------

kafka-1091


Diffs
-----

  core/src/main/scala/kafka/server/KafkaApis.scala 338d1cc6533fd219941f2afb9bc0ea122b368bbe 

Diff: https://reviews.apache.org/r/14676/diff/


Testing
-------


Thanks,

Jun Rao


Re: Review Request 14676: Patch for KAFKA-1091

Posted by Guozhang Wang <gu...@linkedin.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14676/#review27074
-----------------------------------------------------------

Ship it!


Ship It!

- Guozhang Wang


On Oct. 16, 2013, 5:19 p.m., Jun Rao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14676/
> -----------------------------------------------------------
> 
> (Updated Oct. 16, 2013, 5:19 p.m.)
> 
> 
> Review request for kafka.
> 
> 
> Bugs: KAFKA-1091
>     https://issues.apache.org/jira/browse/KAFKA-1091
> 
> 
> Repository: kafka
> 
> 
> Description
> -------
> 
> kafka-1091
> 
> 
> Diffs
> -----
> 
>   core/src/main/scala/kafka/server/KafkaApis.scala 338d1cc6533fd219941f2afb9bc0ea122b368bbe 
> 
> Diff: https://reviews.apache.org/r/14676/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jun Rao
> 
>


Re: Review Request 14676: Patch for KAFKA-1091

Posted by joel koshy <jj...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14676/#review27080
-----------------------------------------------------------

Ship it!


Ship It!

- joel koshy


On Oct. 16, 2013, 5:19 p.m., Jun Rao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14676/
> -----------------------------------------------------------
> 
> (Updated Oct. 16, 2013, 5:19 p.m.)
> 
> 
> Review request for kafka.
> 
> 
> Bugs: KAFKA-1091
>     https://issues.apache.org/jira/browse/KAFKA-1091
> 
> 
> Repository: kafka
> 
> 
> Description
> -------
> 
> kafka-1091
> 
> 
> Diffs
> -----
> 
>   core/src/main/scala/kafka/server/KafkaApis.scala 338d1cc6533fd219941f2afb9bc0ea122b368bbe 
> 
> Diff: https://reviews.apache.org/r/14676/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jun Rao
> 
>


Re: Review Request 14676: Patch for KAFKA-1091

Posted by Swapnil Ghike <sg...@linkedin.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14676/#review27072
-----------------------------------------------------------

Ship it!


Ship It!

- Swapnil Ghike


On Oct. 16, 2013, 5:19 p.m., Jun Rao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14676/
> -----------------------------------------------------------
> 
> (Updated Oct. 16, 2013, 5:19 p.m.)
> 
> 
> Review request for kafka.
> 
> 
> Bugs: KAFKA-1091
>     https://issues.apache.org/jira/browse/KAFKA-1091
> 
> 
> Repository: kafka
> 
> 
> Description
> -------
> 
> kafka-1091
> 
> 
> Diffs
> -----
> 
>   core/src/main/scala/kafka/server/KafkaApis.scala 338d1cc6533fd219941f2afb9bc0ea122b368bbe 
> 
> Diff: https://reviews.apache.org/r/14676/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jun Rao
> 
>


Re: Review Request 14676: Patch for KAFKA-1091

Posted by Neha Narkhede <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14676/#review27085
-----------------------------------------------------------

Ship it!


Ship It!

- Neha Narkhede


On Oct. 16, 2013, 5:19 p.m., Jun Rao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14676/
> -----------------------------------------------------------
> 
> (Updated Oct. 16, 2013, 5:19 p.m.)
> 
> 
> Review request for kafka.
> 
> 
> Bugs: KAFKA-1091
>     https://issues.apache.org/jira/browse/KAFKA-1091
> 
> 
> Repository: kafka
> 
> 
> Description
> -------
> 
> kafka-1091
> 
> 
> Diffs
> -----
> 
>   core/src/main/scala/kafka/server/KafkaApis.scala 338d1cc6533fd219941f2afb9bc0ea122b368bbe 
> 
> Diff: https://reviews.apache.org/r/14676/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jun Rao
> 
>