You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/06/03 08:33:26 UTC

[GitHub] [flink] rmetzger opened a new pull request #12458: [FLINK-17404] Make sure netty 3.10.6 is used in flink-runtime

rmetzger opened a new pull request #12458:
URL: https://github.com/apache/flink/pull/12458


   Due to the recent changes in https://issues.apache.org/jira/browse/FLINK-11086 ("Add support for Hadoop 3"),
   the shaded netty dependency in flink-runtime changed depending on the Hadoop dependency version.
   
   The Hadoop 3 change affects the Netty version of flink-runtime depending on the hadoop version you are compiling Flink with:
   - our akka expects netty 3.10.6
   - with Hadoop 2.4.1 and Hadoop 2.8.3, flink-runtime shades netty 3.6.2 (the e2e test passes)
   - with Hadoop 3.1.3 netty is at 3.10.5 (the e2e test fails reliably)
   
   We add Netty 3.10.6 as a dependency to flink-runtime to make sure it is not overridden by any other dependencies.
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #12458: [FLINK-17404] Make sure netty 3.10.6 is used in flink-runtime

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12458:
URL: https://github.com/apache/flink/pull/12458#issuecomment-638063732


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "ddd425d69bce784da024e4e81a4128104a2b4689",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2622",
       "triggerID" : "ddd425d69bce784da024e4e81a4128104a2b4689",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * ddd425d69bce784da024e4e81a4128104a2b4689 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2622) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #12458: [FLINK-17404] Make sure netty 3.10.6 is used in flink-runtime

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12458:
URL: https://github.com/apache/flink/pull/12458#issuecomment-638063732


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "ddd425d69bce784da024e4e81a4128104a2b4689",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "ddd425d69bce784da024e4e81a4128104a2b4689",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * ddd425d69bce784da024e4e81a4128104a2b4689 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] rmetzger commented on pull request #12458: [FLINK-17404] Make sure netty 3.10.6 is used in flink-runtime

Posted by GitBox <gi...@apache.org>.
rmetzger commented on pull request #12458:
URL: https://github.com/apache/flink/pull/12458#issuecomment-638918828


   Thanks a lot for the review!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #12458: [FLINK-17404] Make sure netty 3.10.6 is used in flink-runtime

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12458:
URL: https://github.com/apache/flink/pull/12458#issuecomment-638063732


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "ddd425d69bce784da024e4e81a4128104a2b4689",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2622",
       "triggerID" : "ddd425d69bce784da024e4e81a4128104a2b4689",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * ddd425d69bce784da024e4e81a4128104a2b4689 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2622) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] rmetzger merged pull request #12458: [FLINK-17404] Make sure netty 3.10.6 is used in flink-runtime

Posted by GitBox <gi...@apache.org>.
rmetzger merged pull request #12458:
URL: https://github.com/apache/flink/pull/12458


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #12458: [FLINK-17404] Make sure netty 3.10.6 is used in flink-runtime

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12458:
URL: https://github.com/apache/flink/pull/12458#issuecomment-638049970


   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit ddd425d69bce784da024e4e81a4128104a2b4689 (Wed Jun 03 08:37:51 UTC 2020)
   
   **Warnings:**
    * **1 pom.xml files were touched**: Check for build and licensing issues.
    * No documentation files were touched! Remember to keep the Flink docs up to date!
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org