You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pinot.apache.org by GitBox <gi...@apache.org> on 2018/11/19 23:51:43 UTC

[GitHub] apucher closed pull request #3517: [TE] rootcause - prevent add-to-chart popup by default

apucher closed pull request #3517: [TE] rootcause - prevent add-to-chart popup by default
URL: https://github.com/apache/incubator-pinot/pull/3517
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/thirdeye/thirdeye-frontend/app/pods/rootcause/template.hbs b/thirdeye/thirdeye-frontend/app/pods/rootcause/template.hbs
index 85c9a13178..304a8f47ee 100644
--- a/thirdeye/thirdeye-frontend/app/pods/rootcause/template.hbs
+++ b/thirdeye/thirdeye-frontend/app/pods/rootcause/template.hbs
@@ -145,9 +145,8 @@
             <a class="thirdeye-link thirdeye-link--settings" {{action "onPrimarySelection"}}>
               + add to chart
               {{#tooltip-on-element
-                class="te-tooltip"
-                isShown=metricUrn}}
-                Click here to load metric
+                class="te-tooltip"}}
+                Click here to add the selected metric to the timeseries chart
               {{/tooltip-on-element}}
             </a>
           {{/if}}


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pinot.apache.org
For additional commands, e-mail: dev-help@pinot.apache.org