You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/11/24 05:53:10 UTC
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 opened a new pull request #498: examples/cctye: change std::isascii to isascii
xiaoxiang781216 opened a new pull request #498:
URL: https://github.com/apache/incubator-nuttx-apps/pull/498
## Summary
since isascii isn't a standard defined function and then
may not exist in all cctype header file(e.g. libc++):
cctype_main.cxx: In function 'int cctype_main(int, char**)':
cctype_main.cxx:64:45: error: 'isascii' is not a member of 'std'; did you mean 'isascii'?
64 | std::isspace(i), std::isascii(i), std::isprint(i), std::isgraph(i),
| ^~~~~~~
## Impact
## Testing
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] yamt commented on pull request #498: examples/cctye: change std::isascii to isascii
Posted by GitBox <gi...@apache.org>.
yamt commented on pull request #498:
URL: https://github.com/apache/incubator-nuttx-apps/pull/498#issuecomment-734519485
for the purpose of this code (cctype example) i guess it's better to add a code comment to explain the situation.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on pull request #498: examples/cctye: change std::isascii to isascii
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #498:
URL: https://github.com/apache/incubator-nuttx-apps/pull/498#issuecomment-732715574
depends on https://github.com/apache/incubator-nuttx-apps/pull/499
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] jerpelea commented on pull request #498: examples/cctye: change std::isascii to isascii
Posted by GitBox <gi...@apache.org>.
jerpelea commented on pull request #498:
URL: https://github.com/apache/incubator-nuttx-apps/pull/498#issuecomment-732698018
@xiaoxiang781216 please fix the build warnings
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] yamt merged pull request #498: examples/cctye: change std::isascii to isascii
Posted by GitBox <gi...@apache.org>.
yamt merged pull request #498:
URL: https://github.com/apache/incubator-nuttx-apps/pull/498
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org