You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kafka.apache.org by ju...@apache.org on 2016/10/24 23:18:29 UTC
kafka git commit: KAFKA-2089; Increase metadata wait time in unit test
Repository: kafka
Updated Branches:
refs/heads/trunk b2fa0d75d -> 1fc450fdb
KAFKA-2089; Increase metadata wait time in unit test
Increase timeout in test to avoid transient failures due to long GC or slow machine.
Author: Rajini Sivaram <ra...@googlemail.com>
Reviewers: Jun Rao <ju...@gmail.com>
Closes #2057 from rajinisivaram/KAFKA-2089
Project: http://git-wip-us.apache.org/repos/asf/kafka/repo
Commit: http://git-wip-us.apache.org/repos/asf/kafka/commit/1fc450fd
Tree: http://git-wip-us.apache.org/repos/asf/kafka/tree/1fc450fd
Diff: http://git-wip-us.apache.org/repos/asf/kafka/diff/1fc450fd
Branch: refs/heads/trunk
Commit: 1fc450fdb5f7b16c3bfb39832d7fe348995e2cf4
Parents: b2fa0d7
Author: Rajini Sivaram <ra...@googlemail.com>
Authored: Mon Oct 24 16:18:23 2016 -0700
Committer: Jun Rao <ju...@gmail.com>
Committed: Mon Oct 24 16:18:23 2016 -0700
----------------------------------------------------------------------
.../src/test/java/org/apache/kafka/clients/MetadataTest.java | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/kafka/blob/1fc450fd/clients/src/test/java/org/apache/kafka/clients/MetadataTest.java
----------------------------------------------------------------------
diff --git a/clients/src/test/java/org/apache/kafka/clients/MetadataTest.java b/clients/src/test/java/org/apache/kafka/clients/MetadataTest.java
index 333a072..1f4f770 100644
--- a/clients/src/test/java/org/apache/kafka/clients/MetadataTest.java
+++ b/clients/src/test/java/org/apache/kafka/clients/MetadataTest.java
@@ -59,8 +59,8 @@ public class MetadataTest {
time += refreshBackoffMs;
assertTrue("Update needed now that backoff time expired", metadata.timeToNextUpdate(time) == 0);
String topic = "my-topic";
- Thread t1 = asyncFetch(topic);
- Thread t2 = asyncFetch(topic);
+ Thread t1 = asyncFetch(topic, 500);
+ Thread t2 = asyncFetch(topic, 500);
assertTrue("Awaiting update", t1.isAlive());
assertTrue("Awaiting update", t2.isAlive());
// Perform metadata update when an update is requested on the async fetch thread
@@ -307,12 +307,12 @@ public class MetadataTest {
assertTrue("Unused topic expired when expiry disabled", metadata.containsTopic("topic4"));
}
- private Thread asyncFetch(final String topic) {
+ private Thread asyncFetch(final String topic, final long maxWaitMs) {
Thread thread = new Thread() {
public void run() {
while (metadata.fetch().partitionsForTopic(topic) == null) {
try {
- metadata.awaitUpdate(metadata.requestUpdate(), refreshBackoffMs);
+ metadata.awaitUpdate(metadata.requestUpdate(), maxWaitMs);
} catch (Exception e) {
backgroundError.set(e.toString());
}