You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/04/22 11:34:43 UTC

[GitHub] [shardingsphere] linghengqian opened a new pull request, #17012: Removed use of SimpleDateFormat in IntervalShardingAlgorithm

linghengqian opened a new pull request, #17012:
URL: https://github.com/apache/shardingsphere/pull/17012

   Fixes #16740.
   
   Changes proposed in this pull request:
   - Using `java.text.SimpleDateFormat` is thread-unsafe and should be avoided.
   - In addition, the `this.getDateTimePattern()` method is called here, bypassing the `this.init()` of the algorithm class, which means that when the rule is updated, the result obtained by the `getDateTimePattern()` method may be the same as `private DateTimeFormatter` dateTimeFormatter property inconsistency corner case.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] terrymanu merged pull request #17012: Remove use of SimpleDateFormat in IntervalShardingAlgorithm

Posted by GitBox <gi...@apache.org>.

terrymanu merged PR #17012:
URL: https://github.com/apache/shardingsphere/pull/17012


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org