[jira] [Work logged] (BEAM-13563) Generalize AWS client provider to be independent of client type

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/BEAM-13563?focusedWorklogId=717856&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-717856 ]

ASF GitHub Bot logged work on BEAM-13563:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 31/Jan/22 12:03
            Start Date: 31/Jan/22 12:03
    Worklog Time Spent: 10m 
      Work Description: mosche commented on pull request #16657:
URL: https://github.com/apache/beam/pull/16657#issuecomment-1025667141


   R: @aromanenko-dev 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 717856)
    Time Spent: 20m  (was: 10m)

> Generalize AWS client provider to be independent of client type
> ---------------------------------------------------------------
>
>                 Key: BEAM-13563
>                 URL: https://issues.apache.org/jira/browse/BEAM-13563
>             Project: Beam
>          Issue Type: Improvement
>          Components: io-java-aws
>            Reporter: Moritz Mack
>            Priority: P3
>              Labels: aws-sdk-v2
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> Currently each AWS IO uses its own client provider, in some cases also separate ones for sync and async clients.
> Besides adding lots of boilerplate code across these IOs, this makes it impossible to switch to an async implementation without breaking APIs. 
> The approach below would require only one common client provider to build all kinds of clients:
> {code:java}
> public <BuilderT extends AwsClientBuilder<BuilderT, ClientT>, ClientT> ClientT buildClient(BuilderT builder) {
>   if (endpoint != null) {
>     builder.endpointOverride(URI.create(endpoint));
>   }
>   return builder
>       .credentialsProvider(credentialsProvider)
>       .region(Region.of(region))
>       .build();
> }
> buildClient(DynamoDbClient.builder());
> buildClient(DynamoDbAsyncClient.builder());
> buildClient(S3Client.builder());
> buildClient(S3AsyncClient.builder());
> ...{code}



--
This message was sent by Atlassian Jira
(v8.20.1#820001)