You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/03/23 06:54:47 UTC

[GitHub] [flink-table-store] JingsongLi opened a new pull request #57: [FLINK-26791] Finish projection push down for table store

JingsongLi opened a new pull request #57:
URL: https://github.com/apache/flink-table-store/pull/57


   Finish two TODOs in table store:
   
   - support projection push down for log store
   - support projection push down for non-primary-key


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink-table-store] LadyForest commented on a change in pull request #57: [FLINK-26791] Finish projection push down for table store

Posted by GitBox <gi...@apache.org>.
LadyForest commented on a change in pull request #57:
URL: https://github.com/apache/flink-table-store/pull/57#discussion_r833043868



##########
File path: flink-table-store-connector/src/main/java/org/apache/flink/table/store/connector/source/FileStoreSource.java
##########
@@ -93,17 +93,22 @@ public Boundedness getBoundedness() {
             read.withDropDelete(false);
         }
 
+        int[][] valueCountProject = null;

Review comment:
       Nit: is there a better naming alternative for `valueCountProject`?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink-table-store] LadyForest commented on a change in pull request #57: [FLINK-26791] Finish projection push down for table store

Posted by GitBox <gi...@apache.org>.
LadyForest commented on a change in pull request #57:
URL: https://github.com/apache/flink-table-store/pull/57#discussion_r833052419



##########
File path: flink-table-store-connector/src/main/java/org/apache/flink/table/store/connector/source/FileStoreSource.java
##########
@@ -93,17 +93,22 @@ public Boundedness getBoundedness() {
             read.withDropDelete(false);
         }
 
+        int[][] valueCountProject = null;
         if (projectedFields != null) {
             if (valueCountMode) {
-                // TODO when isContinuous is false, don't project keys, and add key projection to
-                // split reader
-                read.withKeyProjection(projectedFields);
+                // when isContinuous is false, don't project keys, otherwise, there is no way to

Review comment:
       Nit: personally, I think the current comment is not so straightforward. What about "push projection to file store for better performance under continuous read mode, because the merge cannot be performed anyway"




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink-table-store] JingsongLi merged pull request #57: [FLINK-26791] Finish projection push down for table store

Posted by GitBox <gi...@apache.org>.
JingsongLi merged pull request #57:
URL: https://github.com/apache/flink-table-store/pull/57


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink-table-store] LadyForest commented on a change in pull request #57: [FLINK-26791] Finish projection push down for table store

Posted by GitBox <gi...@apache.org>.
LadyForest commented on a change in pull request #57:
URL: https://github.com/apache/flink-table-store/pull/57#discussion_r833081896



##########
File path: flink-table-store-kafka/src/main/java/org/apache/flink/table/store/kafka/KafkaLogDeserializationSchema.java
##########
@@ -85,22 +101,50 @@ public RowData deserialize(ConsumerRecord<byte[], byte[]> record) {
     }
 
     @Override
-    public void deserialize(ConsumerRecord<byte[], byte[]> record, Collector<RowData> out)
+    public void deserialize(
+            ConsumerRecord<byte[], byte[]> record, Collector<RowData> underCollector)

Review comment:
       what's the point of renaming `out` to `underCollector`?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink-table-store] JingsongLi commented on a change in pull request #57: [FLINK-26791] Finish projection push down for table store

Posted by GitBox <gi...@apache.org>.
JingsongLi commented on a change in pull request #57:
URL: https://github.com/apache/flink-table-store/pull/57#discussion_r833115393



##########
File path: flink-table-store-kafka/src/main/java/org/apache/flink/table/store/kafka/KafkaLogDeserializationSchema.java
##########
@@ -85,22 +101,50 @@ public RowData deserialize(ConsumerRecord<byte[], byte[]> record) {
     }
 
     @Override
-    public void deserialize(ConsumerRecord<byte[], byte[]> record, Collector<RowData> out)
+    public void deserialize(
+            ConsumerRecord<byte[], byte[]> record, Collector<RowData> underCollector)

Review comment:
       Avoid being misused, we should use new `collector`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink-table-store] JingsongLi commented on a change in pull request #57: [FLINK-26791] Finish projection push down for table store

Posted by GitBox <gi...@apache.org>.
JingsongLi commented on a change in pull request #57:
URL: https://github.com/apache/flink-table-store/pull/57#discussion_r833127643



##########
File path: flink-table-store-connector/src/main/java/org/apache/flink/table/store/connector/source/FileStoreSource.java
##########
@@ -93,17 +93,22 @@ public Boundedness getBoundedness() {
             read.withDropDelete(false);
         }
 
+        int[][] valueCountProject = null;

Review comment:
       valueCountModeProjects




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org