You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/09/25 08:30:21 UTC

[GitHub] [flink] pnowojski opened a new pull request #13478: [FLINK-19411][task] Fix construction of MultipleInputStreamTask with union inputs

pnowojski opened a new pull request #13478:
URL: https://github.com/apache/flink/pull/13478


   Previously number of input gates was assumed to be the same as number of logical inputs, which is not true in case of union inputs.
   
   This PR depends on https://github.com/apache/flink/pull/13466. All commits except the last one are from that other PR.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (yes / **no**)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
     - The serializers: (yes / **no** / don't know)
     - The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
     - The S3 file system connector: (yes / **no** / don't know)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (yes / **no**)
     - If yes, how is the feature documented? (**not applicable** / docs / JavaDocs / not documented)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #13478: [FLINK-19411][task] Fix construction of MultipleInputStreamTask with union inputs

Posted by GitBox <gi...@apache.org>.

flinkbot edited a comment on pull request #13478:
URL: https://github.com/apache/flink/pull/13478#issuecomment-698809939


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "0f0b85e13a86a7425a950b6819af09f20ccc1768",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6951",
       "triggerID" : "0f0b85e13a86a7425a950b6819af09f20ccc1768",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 0f0b85e13a86a7425a950b6819af09f20ccc1768 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6951) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #13478: [FLINK-19411][task] Fix construction of MultipleInputStreamTask with union inputs

Posted by GitBox <gi...@apache.org>.

flinkbot commented on pull request #13478:
URL: https://github.com/apache/flink/pull/13478#issuecomment-698809939


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "0f0b85e13a86a7425a950b6819af09f20ccc1768",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "0f0b85e13a86a7425a950b6819af09f20ccc1768",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 0f0b85e13a86a7425a950b6819af09f20ccc1768 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #13478: [FLINK-19411][task] Fix construction of MultipleInputStreamTask with union inputs

Posted by GitBox <gi...@apache.org>.

flinkbot edited a comment on pull request #13478:
URL: https://github.com/apache/flink/pull/13478#issuecomment-698809939


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "0f0b85e13a86a7425a950b6819af09f20ccc1768",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6951",
       "triggerID" : "0f0b85e13a86a7425a950b6819af09f20ccc1768",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 0f0b85e13a86a7425a950b6819af09f20ccc1768 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6951) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #13478: [FLINK-19411][task] Fix construction of MultipleInputStreamTask with union inputs

Posted by GitBox <gi...@apache.org>.

flinkbot edited a comment on pull request #13478:
URL: https://github.com/apache/flink/pull/13478#issuecomment-698809939






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #13478: [FLINK-19411][task] Fix construction of MultipleInputStreamTask with union inputs

Posted by GitBox <gi...@apache.org>.

flinkbot edited a comment on pull request #13478:
URL: https://github.com/apache/flink/pull/13478#issuecomment-698800040

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

## Automated Checks
Last check on commit 02aa9969825717890772997f583ff0b3751b30be (Fri Feb 19 07:28:02 UTC 2021)

**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!

<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress

* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.

Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:

- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #13478: [FLINK-19411][task] Fix construction of MultipleInputStreamTask with union inputs

Posted by GitBox <gi...@apache.org>.

flinkbot commented on pull request #13478:
URL: https://github.com/apache/flink/pull/13478#issuecomment-698800040

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

## Automated Checks
Last check on commit 0f0b85e13a86a7425a950b6819af09f20ccc1768 (Fri Sep 25 08:32:33 UTC 2020)

**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!

<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] pnowojski merged pull request #13478: [FLINK-19411][task] Fix construction of MultipleInputStreamTask with union inputs

Posted by GitBox <gi...@apache.org>.

pnowojski merged pull request #13478:
URL: https://github.com/apache/flink/pull/13478


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #13478: [FLINK-19411][task] Fix construction of MultipleInputStreamTask with union inputs

Posted by GitBox <gi...@apache.org>.

flinkbot commented on pull request #13478:
URL: https://github.com/apache/flink/pull/13478#issuecomment-698800040






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org