[GitHub] [arrow-datafusion] wolffcm commented on a diff in pull request #6184: refactor: optimizer shouldn't assume failed rules are internal error

["wolffcm (via GitHub)" <gi...@apache.org>]

wolffcm commented on code in PR #6184:
URL: https://github.com/apache/arrow-datafusion/pull/6184#discussion_r1181763019


##########
datafusion/core/tests/sqllogictests/test_files/timestamps.slt:
##########
@@ -317,11 +317,11 @@ select
 ----
 08:09:10.123456789 13:14:15.123456 13:14:15.123 13:14:15
 
-query error Cannot cast string 'not a time' to value of Time64\(Nanosecond\) type\. This was likely caused by a bug in DataFusion's code and we would welcome that you file an bug report in our issue tracker
+query error Cannot cast string 'not a time' to value of Time64\(Nanosecond\) type
 SELECT TIME 'not a time' as time;
 
 # invalid time
-query error Cannot cast string '24:01:02' to value of Time64\(Nanosecond\) type\. This was likely caused by a bug in DataFusion's code and we would welcome that you file an bug report in our issue tracker
+query error Cannot cast string '24:01:02' to value of Time64\(Nanosecond\) type

Review Comment:
   The text following `query error` is a regular expression, so the test will pass without all the text. I could add the first part of the message, but it wasn't there to start with.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org