You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by j....@gmail.com on 2015/03/10 19:34:53 UTC
Re: Review Request 31386: HIVE-9555 assorted ORC refactorings for
LLAP on trunk
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31386/#review75904
-----------------------------------------------------------
common/src/java/org/apache/hadoop/hive/common/DiskRange.java
<https://reviews.apache.org/r/31386/#comment123230>
does not override hashcode.
ql/src/java/org/apache/hadoop/hive/ql/io/orc/InStream.java
<https://reviews.apache.org/r/31386/#comment123236>
Can you remove the fileName? We don't really need it except for logging. HIVE-9841 logs the fileName at high level whenever exception is thrown.
ql/src/java/org/apache/hadoop/hive/ql/io/orc/InStream.java
<https://reviews.apache.org/r/31386/#comment123237>
Same here. I don't think we make use of fileName anywhere.
ql/src/java/org/apache/hadoop/hive/ql/io/orc/InStream.java
<https://reviews.apache.org/r/31386/#comment123239>
Same here.
ql/src/java/org/apache/hadoop/hive/ql/io/orc/MetadataReader.java
<https://reviews.apache.org/r/31386/#comment123242>
nit: Implement AutoCloseable? Since we moved to JDK7 we can make use of try-with-resources
ql/src/java/org/apache/hadoop/hive/ql/io/orc/RecordReaderUtils.java
<https://reviews.apache.org/r/31386/#comment123249>
Why does it return 0? Is it a bug in HDFS?
- Prasanth_J
On Feb. 24, 2015, 11:35 p.m., Sergey Shelukhin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31386/
> -----------------------------------------------------------
>
> (Updated Feb. 24, 2015, 11:35 p.m.)
>
>
> Review request for hive and Prasanth_J.
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> see jira
>
>
> Diffs
> -----
>
> common/src/java/org/apache/hadoop/hive/common/DiskRange.java PRE-CREATION
> common/src/java/org/apache/hadoop/hive/common/DiskRangeList.java PRE-CREATION
> ql/src/java/org/apache/hadoop/hive/ql/io/orc/CompressionCodec.java 5e2d880
> ql/src/java/org/apache/hadoop/hive/ql/io/orc/InStream.java 62c6f8d
> ql/src/java/org/apache/hadoop/hive/ql/io/orc/MetadataReader.java PRE-CREATION
> ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcFile.java 25bb15a
> ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcInputFormat.java 498ee14
> ql/src/java/org/apache/hadoop/hive/ql/io/orc/PositionProvider.java 3daa9ba
> ql/src/java/org/apache/hadoop/hive/ql/io/orc/Reader.java f85c21b
> ql/src/java/org/apache/hadoop/hive/ql/io/orc/ReaderImpl.java 03f8085
> ql/src/java/org/apache/hadoop/hive/ql/io/orc/RecordReaderImpl.java 2745bee
> ql/src/java/org/apache/hadoop/hive/ql/io/orc/RecordReaderUtils.java PRE-CREATION
> ql/src/java/org/apache/hadoop/hive/ql/io/orc/RunLengthIntegerReaderV2.java 4057036
> ql/src/java/org/apache/hadoop/hive/ql/io/orc/VectorizedOrcInputFormat.java 23e5f27
> ql/src/java/org/apache/hadoop/hive/ql/io/orc/WriterImpl.java cb7c103
> ql/src/java/org/apache/hadoop/hive/ql/io/sarg/SearchArgumentFactory.java f4a2e65
> ql/src/test/org/apache/hadoop/hive/ql/io/orc/TestInStream.java 0ea4a7b
> ql/src/test/org/apache/hadoop/hive/ql/io/orc/TestInputOutputFormat.java 2cc3d7a
> ql/src/test/org/apache/hadoop/hive/ql/io/orc/TestIntegerCompressionReader.java 591ec3f
> ql/src/test/org/apache/hadoop/hive/ql/io/orc/TestRecordReaderImpl.java 326dde4
>
> Diff: https://reviews.apache.org/r/31386/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Sergey Shelukhin
>
>
Re: Review Request 31386: HIVE-9555 assorted ORC refactorings for
LLAP on trunk
Posted by Sergey Shelukhin <se...@hortonworks.com>.
> On March 10, 2015, 6:34 p.m., Prasanth_J wrote:
> > ql/src/java/org/apache/hadoop/hive/ql/io/orc/MetadataReader.java, line 32
> > <https://reviews.apache.org/r/31386/diff/1/?file=874501#file874501line32>
> >
> > nit: Implement AutoCloseable? Since we moved to JDK7 we can make use of try-with-resources
separate JIRA for all ORC classes?
> On March 10, 2015, 6:34 p.m., Prasanth_J wrote:
> > ql/src/java/org/apache/hadoop/hive/ql/io/orc/RecordReaderUtils.java, line 268
> > <https://reviews.apache.org/r/31386/diff/1/?file=874508#file874508line268>
> >
> > Why does it return 0? Is it a bug in HDFS?
changed to assert. It was a suspected problem...
- Sergey
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31386/#review75904
-----------------------------------------------------------
On Feb. 24, 2015, 11:35 p.m., Sergey Shelukhin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31386/
> -----------------------------------------------------------
>
> (Updated Feb. 24, 2015, 11:35 p.m.)
>
>
> Review request for hive and Prasanth_J.
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> see jira
>
>
> Diffs
> -----
>
> common/src/java/org/apache/hadoop/hive/common/DiskRange.java PRE-CREATION
> common/src/java/org/apache/hadoop/hive/common/DiskRangeList.java PRE-CREATION
> ql/src/java/org/apache/hadoop/hive/ql/io/orc/CompressionCodec.java 5e2d880
> ql/src/java/org/apache/hadoop/hive/ql/io/orc/InStream.java 62c6f8d
> ql/src/java/org/apache/hadoop/hive/ql/io/orc/MetadataReader.java PRE-CREATION
> ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcFile.java 25bb15a
> ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcInputFormat.java 498ee14
> ql/src/java/org/apache/hadoop/hive/ql/io/orc/PositionProvider.java 3daa9ba
> ql/src/java/org/apache/hadoop/hive/ql/io/orc/Reader.java f85c21b
> ql/src/java/org/apache/hadoop/hive/ql/io/orc/ReaderImpl.java 03f8085
> ql/src/java/org/apache/hadoop/hive/ql/io/orc/RecordReaderImpl.java 2745bee
> ql/src/java/org/apache/hadoop/hive/ql/io/orc/RecordReaderUtils.java PRE-CREATION
> ql/src/java/org/apache/hadoop/hive/ql/io/orc/RunLengthIntegerReaderV2.java 4057036
> ql/src/java/org/apache/hadoop/hive/ql/io/orc/VectorizedOrcInputFormat.java 23e5f27
> ql/src/java/org/apache/hadoop/hive/ql/io/orc/WriterImpl.java cb7c103
> ql/src/java/org/apache/hadoop/hive/ql/io/sarg/SearchArgumentFactory.java f4a2e65
> ql/src/test/org/apache/hadoop/hive/ql/io/orc/TestInStream.java 0ea4a7b
> ql/src/test/org/apache/hadoop/hive/ql/io/orc/TestInputOutputFormat.java 2cc3d7a
> ql/src/test/org/apache/hadoop/hive/ql/io/orc/TestIntegerCompressionReader.java 591ec3f
> ql/src/test/org/apache/hadoop/hive/ql/io/orc/TestRecordReaderImpl.java 326dde4
>
> Diff: https://reviews.apache.org/r/31386/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Sergey Shelukhin
>
>