You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by "jcesarmobile (via GitHub)" <gi...@apache.org> on 2023/03/10 00:43:53 UTC

[GitHub] [cordova-plugin-dialogs] jcesarmobile commented on pull request #157: (iOS) Add support for red cancel button on iOS

jcesarmobile commented on PR #157:
URL: https://github.com/apache/cordova-plugin-dialogs/pull/157#issuecomment-1463040947

   Going to close since it's breaking and opinionated
   `UIAlertActionStyleDestructive` should be used for destructive actions but it's being used for Cancel and No, I think `UIAlertActionStyleCancel` would suit those buttons better.
   
   not sure if it would be possible to modify the plugin to allow setting buttons as strings as it does now but also as objects where you can pass the string and the style, so that way is not breaking
   
   or deprecating "buttonLabels" and adding "buttons" that would take the object with label and style.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org