You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Alexander Rukletsov <al...@mesosphere.io> on 2015/03/05 22:04:45 UTC
Review Request 31775: Removed Master::Flags dependency from Allocator.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31775/
-----------------------------------------------------------
Review request for mesos, Kapil Arya, Michael Park, and Niklas Nielsen.
Bugs: MESOS-2160
https://issues.apache.org/jira/browse/MESOS-2160
Repository: mesos
Description
-------
On the way to moving allocator to public includes we need to remove the dependency to internal Master::Flags type.
Diffs
-----
src/master/allocator/allocator.hpp b67b8fddbd7a3fffc6fe24d5e77cd1db8cb6f69b
src/master/allocator/mesos/allocator.hpp fb898f1175b61b442204e6e38c69ccc2838a646f
src/master/allocator/mesos/hierarchical.hpp c0b1da75565d9dc7728c5566f01815234163fc47
src/master/master.cpp 68ca19a9ae680e3ae5bd433a9842baf69f2360ec
src/tests/hierarchical_allocator_tests.cpp 93753d1c04159a04a733927a487eb69505438e32
src/tests/mesos.hpp 45e35204d1aa876fa0c871acf0f21afcd5ababe8
Diff: https://reviews.apache.org/r/31775/diff/
Testing
-------
make check (Mac OS 10.9.5, Ubuntu 14.04)
Thanks,
Alexander Rukletsov
Re: Review Request 31775: Removed Master::Flags dependency from
Allocator.
Posted by Kapil Arya <ka...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31775/#review76801
-----------------------------------------------------------
Ship it!
Ship It!
- Kapil Arya
On March 13, 2015, 3:30 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31775/
> -----------------------------------------------------------
>
> (Updated March 13, 2015, 3:30 p.m.)
>
>
> Review request for mesos, Kapil Arya, Michael Park, and Niklas Nielsen.
>
>
> Bugs: MESOS-2160
> https://issues.apache.org/jira/browse/MESOS-2160
>
>
> Repository: mesos
>
>
> Description
> -------
>
> On the way to moving allocator to public includes we need to remove the dependency to internal Master::Flags type.
>
>
> Diffs
> -----
>
> src/master/allocator/allocator.hpp b67b8fddbd7a3fffc6fe24d5e77cd1db8cb6f69b
> src/master/allocator/mesos/allocator.hpp fb898f1175b61b442204e6e38c69ccc2838a646f
> src/master/allocator/mesos/hierarchical.hpp c0b1da75565d9dc7728c5566f01815234163fc47
> src/master/master.cpp dccd7c635da4b7031cd109bd84e7f17b31777ef1
> src/tests/hierarchical_allocator_tests.cpp 93753d1c04159a04a733927a487eb69505438e32
> src/tests/mesos.hpp 45e35204d1aa876fa0c871acf0f21afcd5ababe8
>
> Diff: https://reviews.apache.org/r/31775/diff/
>
>
> Testing
> -------
>
> make check (Mac OS 10.9.5, Ubuntu 14.04)
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 31775: Removed Master::Flags dependency from
Allocator.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31775/
-----------------------------------------------------------
(Updated April 20, 2015, 1:30 p.m.)
Review request for mesos, Kapil Arya, Michael Park, and Niklas Nielsen.
Changes
-------
Rebased.
Bugs: MESOS-2160
https://issues.apache.org/jira/browse/MESOS-2160
Repository: mesos
Description
-------
On the way to moving allocator to public includes we need to remove the dependency to internal Master::Flags type.
Diffs (updated)
-----
src/master/allocator/allocator.hpp 5e3e6138a36ddd6852ae1875cb967ad8487644e8
src/master/allocator/mesos/allocator.hpp af27a9bd8299cbff01e04b74db47c86bf247b908
src/master/allocator/mesos/hierarchical.hpp 90ac19736fbd56847db925cb497c4e3d9070af0a
src/master/master.cpp e30b951eda2b3b0d5b2a80716f0b32c6bbe041bc
src/tests/hierarchical_allocator_tests.cpp 0b564a74d3f04df46fe52fcbe1bf8d4d1e41c53c
src/tests/mesos.hpp 7744df55a2a31446327da7bd2b16457e90711d22
Diff: https://reviews.apache.org/r/31775/diff/
Testing
-------
make check (Mac OS 10.9.5, CentOS 7.0)
Thanks,
Alexander Rukletsov
Re: Review Request 31775: Removed Master::Flags dependency from
Allocator.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31775/
-----------------------------------------------------------
(Updated April 7, 2015, 12:46 p.m.)
Review request for mesos, Kapil Arya, Michael Park, and Niklas Nielsen.
Changes
-------
Rebased.
Bugs: MESOS-2160
https://issues.apache.org/jira/browse/MESOS-2160
Repository: mesos
Description
-------
On the way to moving allocator to public includes we need to remove the dependency to internal Master::Flags type.
Diffs (updated)
-----
src/master/allocator/allocator.hpp b67b8fddbd7a3fffc6fe24d5e77cd1db8cb6f69b
src/master/allocator/mesos/allocator.hpp fb898f1175b61b442204e6e38c69ccc2838a646f
src/master/allocator/mesos/hierarchical.hpp 9f9a631ee52a3ab194e678f9be139e8dabc7f3db
src/master/master.cpp 618db68ee4163b06e479cf3413eda4b63c9c5a4b
src/tests/hierarchical_allocator_tests.cpp 8861bf398e4bb17b0f74eab4f4af26202447ccef
src/tests/mesos.hpp 0e98572a62ae05437bd2bc800c370ad1a0c43751
Diff: https://reviews.apache.org/r/31775/diff/
Testing
-------
make check (Mac OS 10.9.5, CentOS 7.0)
Thanks,
Alexander Rukletsov
Re: Review Request 31775: Removed Master::Flags dependency from
Allocator.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31775/#review78689
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On April 1, 2015, 2:24 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31775/
> -----------------------------------------------------------
>
> (Updated April 1, 2015, 2:24 p.m.)
>
>
> Review request for mesos, Kapil Arya, Michael Park, and Niklas Nielsen.
>
>
> Bugs: MESOS-2160
> https://issues.apache.org/jira/browse/MESOS-2160
>
>
> Repository: mesos
>
>
> Description
> -------
>
> On the way to moving allocator to public includes we need to remove the dependency to internal Master::Flags type.
>
>
> Diffs
> -----
>
> src/master/allocator/allocator.hpp b67b8fddbd7a3fffc6fe24d5e77cd1db8cb6f69b
> src/master/allocator/mesos/allocator.hpp fb898f1175b61b442204e6e38c69ccc2838a646f
> src/master/allocator/mesos/hierarchical.hpp 9f9a631ee52a3ab194e678f9be139e8dabc7f3db
> src/master/master.cpp 618db68ee4163b06e479cf3413eda4b63c9c5a4b
> src/tests/hierarchical_allocator_tests.cpp 8861bf398e4bb17b0f74eab4f4af26202447ccef
> src/tests/mesos.hpp 0e98572a62ae05437bd2bc800c370ad1a0c43751
>
> Diff: https://reviews.apache.org/r/31775/diff/
>
>
> Testing
> -------
>
> make check (Mac OS 10.9.5, CentOS 7.0)
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 31775: Removed Master::Flags dependency from
Allocator.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31775/
-----------------------------------------------------------
(Updated April 1, 2015, 2:24 p.m.)
Review request for mesos, Kapil Arya, Michael Park, and Niklas Nielsen.
Changes
-------
Addressed Niklas' comment.
Bugs: MESOS-2160
https://issues.apache.org/jira/browse/MESOS-2160
Repository: mesos
Description
-------
On the way to moving allocator to public includes we need to remove the dependency to internal Master::Flags type.
Diffs (updated)
-----
src/master/allocator/allocator.hpp b67b8fddbd7a3fffc6fe24d5e77cd1db8cb6f69b
src/master/allocator/mesos/allocator.hpp fb898f1175b61b442204e6e38c69ccc2838a646f
src/master/allocator/mesos/hierarchical.hpp 9f9a631ee52a3ab194e678f9be139e8dabc7f3db
src/master/master.cpp 618db68ee4163b06e479cf3413eda4b63c9c5a4b
src/tests/hierarchical_allocator_tests.cpp 8861bf398e4bb17b0f74eab4f4af26202447ccef
src/tests/mesos.hpp 0e98572a62ae05437bd2bc800c370ad1a0c43751
Diff: https://reviews.apache.org/r/31775/diff/
Testing
-------
make check (Mac OS 10.9.5, CentOS 7.0)
Thanks,
Alexander Rukletsov
Re: Review Request 31775: Removed Master::Flags dependency from
Allocator.
Posted by Niklas Nielsen <ni...@qni.dk>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31775/#review77511
-----------------------------------------------------------
src/master/allocator/mesos/allocator.hpp
<https://reviews.apache.org/r/31775/#comment125606>
You added a JIRA for this, right? Let's kill the comment then.
- Niklas Nielsen
On March 27, 2015, 9:23 a.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31775/
> -----------------------------------------------------------
>
> (Updated March 27, 2015, 9:23 a.m.)
>
>
> Review request for mesos, Kapil Arya, Michael Park, and Niklas Nielsen.
>
>
> Bugs: MESOS-2160
> https://issues.apache.org/jira/browse/MESOS-2160
>
>
> Repository: mesos
>
>
> Description
> -------
>
> On the way to moving allocator to public includes we need to remove the dependency to internal Master::Flags type.
>
>
> Diffs
> -----
>
> src/master/allocator/allocator.hpp b67b8fddbd7a3fffc6fe24d5e77cd1db8cb6f69b
> src/master/allocator/mesos/allocator.hpp fb898f1175b61b442204e6e38c69ccc2838a646f
> src/master/allocator/mesos/hierarchical.hpp 9f9a631ee52a3ab194e678f9be139e8dabc7f3db
> src/master/master.cpp ffccc1259b62db89404f6aa6225beeb4c9828684
> src/tests/hierarchical_allocator_tests.cpp 8861bf398e4bb17b0f74eab4f4af26202447ccef
> src/tests/mesos.hpp 0e98572a62ae05437bd2bc800c370ad1a0c43751
>
> Diff: https://reviews.apache.org/r/31775/diff/
>
>
> Testing
> -------
>
> make check (Mac OS 10.9.5, CentOS 7.0)
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 31775: Removed Master::Flags dependency from
Allocator.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31775/
-----------------------------------------------------------
(Updated March 27, 2015, 4:23 p.m.)
Review request for mesos, Kapil Arya, Michael Park, and Niklas Nielsen.
Changes
-------
Rebased.
Bugs: MESOS-2160
https://issues.apache.org/jira/browse/MESOS-2160
Repository: mesos
Description
-------
On the way to moving allocator to public includes we need to remove the dependency to internal Master::Flags type.
Diffs (updated)
-----
src/master/allocator/allocator.hpp b67b8fddbd7a3fffc6fe24d5e77cd1db8cb6f69b
src/master/allocator/mesos/allocator.hpp fb898f1175b61b442204e6e38c69ccc2838a646f
src/master/allocator/mesos/hierarchical.hpp 9f9a631ee52a3ab194e678f9be139e8dabc7f3db
src/master/master.cpp ffccc1259b62db89404f6aa6225beeb4c9828684
src/tests/hierarchical_allocator_tests.cpp 8861bf398e4bb17b0f74eab4f4af26202447ccef
src/tests/mesos.hpp 0e98572a62ae05437bd2bc800c370ad1a0c43751
Diff: https://reviews.apache.org/r/31775/diff/
Testing
-------
make check (Mac OS 10.9.5, CentOS 7.0)
Thanks,
Alexander Rukletsov
Re: Review Request 31775: Removed Master::Flags dependency from
Allocator.
Posted by Alexander Rojas <al...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31775/#review77574
-----------------------------------------------------------
Ship it!
Ship It!
- Alexander Rojas
On March 23, 2015, 3:01 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31775/
> -----------------------------------------------------------
>
> (Updated March 23, 2015, 3:01 p.m.)
>
>
> Review request for mesos, Kapil Arya, Michael Park, and Niklas Nielsen.
>
>
> Bugs: MESOS-2160
> https://issues.apache.org/jira/browse/MESOS-2160
>
>
> Repository: mesos
>
>
> Description
> -------
>
> On the way to moving allocator to public includes we need to remove the dependency to internal Master::Flags type.
>
>
> Diffs
> -----
>
> src/master/allocator/allocator.hpp b67b8fddbd7a3fffc6fe24d5e77cd1db8cb6f69b
> src/master/allocator/mesos/allocator.hpp fb898f1175b61b442204e6e38c69ccc2838a646f
> src/master/allocator/mesos/hierarchical.hpp c0b1da75565d9dc7728c5566f01815234163fc47
> src/master/master.cpp dccd7c635da4b7031cd109bd84e7f17b31777ef1
> src/tests/hierarchical_allocator_tests.cpp 93753d1c04159a04a733927a487eb69505438e32
> src/tests/mesos.hpp 45e35204d1aa876fa0c871acf0f21afcd5ababe8
>
> Diff: https://reviews.apache.org/r/31775/diff/
>
>
> Testing
> -------
>
> make check (Mac OS 10.9.5, CentOS 7.0)
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 31775: Removed Master::Flags dependency from
Allocator.
Posted by Michael Park <mc...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31775/#review77475
-----------------------------------------------------------
LGTM!
- Michael Park
On March 23, 2015, 2:01 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31775/
> -----------------------------------------------------------
>
> (Updated March 23, 2015, 2:01 p.m.)
>
>
> Review request for mesos, Kapil Arya, Michael Park, and Niklas Nielsen.
>
>
> Bugs: MESOS-2160
> https://issues.apache.org/jira/browse/MESOS-2160
>
>
> Repository: mesos
>
>
> Description
> -------
>
> On the way to moving allocator to public includes we need to remove the dependency to internal Master::Flags type.
>
>
> Diffs
> -----
>
> src/master/allocator/allocator.hpp b67b8fddbd7a3fffc6fe24d5e77cd1db8cb6f69b
> src/master/allocator/mesos/allocator.hpp fb898f1175b61b442204e6e38c69ccc2838a646f
> src/master/allocator/mesos/hierarchical.hpp c0b1da75565d9dc7728c5566f01815234163fc47
> src/master/master.cpp dccd7c635da4b7031cd109bd84e7f17b31777ef1
> src/tests/hierarchical_allocator_tests.cpp 93753d1c04159a04a733927a487eb69505438e32
> src/tests/mesos.hpp 45e35204d1aa876fa0c871acf0f21afcd5ababe8
>
> Diff: https://reviews.apache.org/r/31775/diff/
>
>
> Testing
> -------
>
> make check (Mac OS 10.9.5, CentOS 7.0)
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 31775: Removed Master::Flags dependency from
Allocator.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31775/
-----------------------------------------------------------
(Updated March 23, 2015, 2:01 p.m.)
Review request for mesos, Kapil Arya, Michael Park, and Niklas Nielsen.
Changes
-------
Rebased.
Bugs: MESOS-2160
https://issues.apache.org/jira/browse/MESOS-2160
Repository: mesos
Description
-------
On the way to moving allocator to public includes we need to remove the dependency to internal Master::Flags type.
Diffs (updated)
-----
src/master/allocator/allocator.hpp b67b8fddbd7a3fffc6fe24d5e77cd1db8cb6f69b
src/master/allocator/mesos/allocator.hpp fb898f1175b61b442204e6e38c69ccc2838a646f
src/master/allocator/mesos/hierarchical.hpp c0b1da75565d9dc7728c5566f01815234163fc47
src/master/master.cpp dccd7c635da4b7031cd109bd84e7f17b31777ef1
src/tests/hierarchical_allocator_tests.cpp 93753d1c04159a04a733927a487eb69505438e32
src/tests/mesos.hpp 45e35204d1aa876fa0c871acf0f21afcd5ababe8
Diff: https://reviews.apache.org/r/31775/diff/
Testing (updated)
-------
make check (Mac OS 10.9.5, CentOS 7.0)
Thanks,
Alexander Rukletsov
Re: Review Request 31775: Removed Master::Flags dependency from
Allocator.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31775/
-----------------------------------------------------------
(Updated March 13, 2015, 7:30 p.m.)
Review request for mesos, Kapil Arya, Michael Park, and Niklas Nielsen.
Changes
-------
Rebased.
Bugs: MESOS-2160
https://issues.apache.org/jira/browse/MESOS-2160
Repository: mesos
Description
-------
On the way to moving allocator to public includes we need to remove the dependency to internal Master::Flags type.
Diffs (updated)
-----
src/master/allocator/allocator.hpp b67b8fddbd7a3fffc6fe24d5e77cd1db8cb6f69b
src/master/allocator/mesos/allocator.hpp fb898f1175b61b442204e6e38c69ccc2838a646f
src/master/allocator/mesos/hierarchical.hpp c0b1da75565d9dc7728c5566f01815234163fc47
src/master/master.cpp dccd7c635da4b7031cd109bd84e7f17b31777ef1
src/tests/hierarchical_allocator_tests.cpp 93753d1c04159a04a733927a487eb69505438e32
src/tests/mesos.hpp 45e35204d1aa876fa0c871acf0f21afcd5ababe8
Diff: https://reviews.apache.org/r/31775/diff/
Testing
-------
make check (Mac OS 10.9.5, Ubuntu 14.04)
Thanks,
Alexander Rukletsov
Re: Review Request 31775: Removed Master::Flags dependency from
Allocator.
Posted by Alexander Rukletsov <ru...@gmail.com>.
> On March 10, 2015, 9:09 p.m., Niklas Nielsen wrote:
> > src/master/allocator/mesos/allocator.hpp, line 46
> > <https://reviews.apache.org/r/31775/diff/1/?file=886126#file886126line46>
> >
> > Let's move to JIRA
It already exists: https://issues.apache.org/jira/browse/MESOS-2285.
- Alexander
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31775/#review75893
-----------------------------------------------------------
On March 5, 2015, 9:04 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31775/
> -----------------------------------------------------------
>
> (Updated March 5, 2015, 9:04 p.m.)
>
>
> Review request for mesos, Kapil Arya, Michael Park, and Niklas Nielsen.
>
>
> Bugs: MESOS-2160
> https://issues.apache.org/jira/browse/MESOS-2160
>
>
> Repository: mesos
>
>
> Description
> -------
>
> On the way to moving allocator to public includes we need to remove the dependency to internal Master::Flags type.
>
>
> Diffs
> -----
>
> src/master/allocator/allocator.hpp b67b8fddbd7a3fffc6fe24d5e77cd1db8cb6f69b
> src/master/allocator/mesos/allocator.hpp fb898f1175b61b442204e6e38c69ccc2838a646f
> src/master/allocator/mesos/hierarchical.hpp c0b1da75565d9dc7728c5566f01815234163fc47
> src/master/master.cpp 68ca19a9ae680e3ae5bd433a9842baf69f2360ec
> src/tests/hierarchical_allocator_tests.cpp 93753d1c04159a04a733927a487eb69505438e32
> src/tests/mesos.hpp 45e35204d1aa876fa0c871acf0f21afcd5ababe8
>
> Diff: https://reviews.apache.org/r/31775/diff/
>
>
> Testing
> -------
>
> make check (Mac OS 10.9.5, Ubuntu 14.04)
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 31775: Removed Master::Flags dependency from
Allocator.
Posted by Niklas Nielsen <ni...@qni.dk>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31775/#review75893
-----------------------------------------------------------
Ship it!
src/master/allocator/mesos/allocator.hpp
<https://reviews.apache.org/r/31775/#comment123220>
Let's move to JIRA
- Niklas Nielsen
On March 5, 2015, 1:04 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31775/
> -----------------------------------------------------------
>
> (Updated March 5, 2015, 1:04 p.m.)
>
>
> Review request for mesos, Kapil Arya, Michael Park, and Niklas Nielsen.
>
>
> Bugs: MESOS-2160
> https://issues.apache.org/jira/browse/MESOS-2160
>
>
> Repository: mesos
>
>
> Description
> -------
>
> On the way to moving allocator to public includes we need to remove the dependency to internal Master::Flags type.
>
>
> Diffs
> -----
>
> src/master/allocator/allocator.hpp b67b8fddbd7a3fffc6fe24d5e77cd1db8cb6f69b
> src/master/allocator/mesos/allocator.hpp fb898f1175b61b442204e6e38c69ccc2838a646f
> src/master/allocator/mesos/hierarchical.hpp c0b1da75565d9dc7728c5566f01815234163fc47
> src/master/master.cpp 68ca19a9ae680e3ae5bd433a9842baf69f2360ec
> src/tests/hierarchical_allocator_tests.cpp 93753d1c04159a04a733927a487eb69505438e32
> src/tests/mesos.hpp 45e35204d1aa876fa0c871acf0f21afcd5ababe8
>
> Diff: https://reviews.apache.org/r/31775/diff/
>
>
> Testing
> -------
>
> make check (Mac OS 10.9.5, Ubuntu 14.04)
>
>
> Thanks,
>
> Alexander Rukletsov
>
>