[GitHub] [druid] ccaominh commented on a change in pull request #9274: Refactoring some codes around ingestion

[GitBox <gi...@apache.org>]

ccaominh commented on a change in pull request #9274: Refactoring some codes around ingestion
URL: https://github.com/apache/druid/pull/9274#discussion_r372137820
 
 

 ##########
 File path: indexing-service/src/main/java/org/apache/druid/indexing/common/task/AbstractBatchIndexTask.java
 ##########
 @@ -194,14 +179,9 @@ public int getPriority()
     return getContextValue(Tasks.PRIORITY_KEY, Tasks.DEFAULT_BATCH_INDEX_TASK_PRIORITY);
   }
 
-  public boolean isUseSegmentLock()
-  {
-    return useSegmentLock;
-  }
-
-  public SegmentLockHelper getSegmentLockHelper()
+  public TaskLockHelper getTaskLockHelper()
   {
-    return segmentLockHelper;
+    return Preconditions.checkNotNull(taskLockHelper, "segmentLockHelper is not initialized yet");
 
 Review comment:
   Update the error message to say "taskLockHelper" instead of "segmentLockHelper"

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org