You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/06/24 12:16:46 UTC

[GitHub] [flink-benchmarks] rkhachatryan commented on a diff in pull request #56: [FLINK-28241] Overridden REQUIREMENTS CHECK DELAY to zero to avoid de…

rkhachatryan commented on code in PR #56:
URL: https://github.com/apache/flink-benchmarks/pull/56#discussion_r906005233


##########
src/main/java/org/apache/flink/benchmark/FlinkEnvironmentContext.java:
##########
@@ -107,6 +110,7 @@ protected Configuration createConfiguration() {
         // It doesn't make sense to wait for the final checkpoint in benchmarks since it only prolongs
         // the test but doesn't give any advantages.
         configuration.set(ExecutionCheckpointingOptions.ENABLE_CHECKPOINTS_AFTER_TASKS_FINISH, false);
+        configuration.set(REQUIREMENTS_CHECK_DELAY, Duration.ZERO);

Review Comment:
   nit: after FLINK-28243, we will likely remove this line. So I'd comment here in the code or mention it in FLINK-28243, or both.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org