You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/01/24 05:56:19 UTC

[GitHub] [dolphinscheduler] caishunfeng commented on a change in pull request #8156: [Bug-7865][MasterServer] retry logic optimization

caishunfeng commented on a change in pull request #8156:
URL: https://github.com/apache/dolphinscheduler/pull/8156#discussion_r790432396



##########
File path: dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/runner/StateWheelExecuteThread.java
##########
@@ -106,63 +118,74 @@ public void addTask4TimeoutCheck(TaskInstance taskInstance) {
             return;
         }
         if (TimeoutFlag.OPEN == taskDefinition.getTimeoutFlag()) {
-            taskInstanceTimeoutCheckList.put(taskInstance.getId(), taskInstance.getProcessInstanceId());
+            taskInstanceTimeoutCheckList.put(taskInstance.getTaskCode(), taskInstance.getProcessInstanceId());

Review comment:
       I had fix it by `TaskInstanceKey`, please take a look again.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org