You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by Tneciv <gi...@git.apache.org> on 2017/05/16 08:53:57 UTC
[GitHub] cordova-android pull request #380: Upgrade build jdk from 6 to 7
GitHub user Tneciv opened a pull request:
https://github.com/apache/cordova-android/pull/380
Upgrade build jdk from 6 to 7
Upgrade build java version from java 6 to 7
### Platforms affected
Android
### What does this PR do?
Upgrade build java version to apply higher jdk features
### What testing has been done on this change?
Test to build apk successful
### Checklist
- [ ] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
- [ ] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
- [ ] Added automated test coverage as appropriate for this change.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Tneciv/cordova-android Tneciv-upgrade-jdk
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-android/pull/380.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #380
----
commit 7e14273847b5b1a5be5a937671be82a8a2d107ff
Author: Tneciv <tn...@gmail.com>
Date: 2017-05-16T08:49:16Z
Upgrade build jdk from 6 to 7
Upgrade build java version from java6 to 7
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-android issue #380: Upgrade build jdk from 6 to 7
Posted by infil00p <gi...@git.apache.org>.
Github user infil00p commented on the issue:
https://github.com/apache/cordova-android/pull/380
I think this should be discussed on the list. There's upsides and downsides to this, and it could attract more developers to adopt JDK 7 and newer Java features.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-android issue #380: Upgrade build jdk from 6 to 7
Posted by infil00p <gi...@git.apache.org>.
Github user infil00p commented on the issue:
https://github.com/apache/cordova-android/pull/380
Yeah, I'm not sure this is such a great plan.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-android issue #380: Upgrade build jdk from 6 to 7
Posted by filmaj <gi...@git.apache.org>.
Github user filmaj commented on the issue:
https://github.com/apache/cordova-android/pull/380
@infil00p so what's the plan here? Are these changes to readme/JDK requirements unfounded? Close this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-android issue #380: Upgrade build jdk from 6 to 7
Posted by filmaj <gi...@git.apache.org>.
Github user filmaj commented on the issue:
https://github.com/apache/cordova-android/pull/380
Is a Java upgrade required?
If so, then we should also update the [README's requirements section](https://github.com/apache/cordova-android/blob/master/README.md#requires).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-android issue #380: Upgrade build jdk from 6 to 7
Posted by codecov-io <gi...@git.apache.org>.
Github user codecov-io commented on the issue:
https://github.com/apache/cordova-android/pull/380
# [Codecov](https://codecov.io/gh/apache/cordova-android/pull/380?src=pr&el=h1) Report
> Merging [#380](https://codecov.io/gh/apache/cordova-android/pull/380?src=pr&el=desc) into [master](https://codecov.io/gh/apache/cordova-android/commit/d97250f9683518e255d30a4a13a6d3f01dbc9a9b?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/cordova-android/pull/380?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #380 +/- ##
=======================================
Coverage 39.52% 39.52%
=======================================
Files 16 16
Lines 1551 1551
Branches 277 277
=======================================
Hits 613 613
Misses 938 938
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-android/pull/380?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-android/pull/380?src=pr&el=footer). Last update [d97250f...7e14273](https://codecov.io/gh/apache/cordova-android/pull/380?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org