You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Apoorv Naik <na...@gmail.com> on 2017/03/08 22:10:09 UTC
Review Request 57434: ATLAS-1659: Full text changes when tags are
added/removed
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57434/
-----------------------------------------------------------
Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Sarath Subramanian, Suma Shivaprasad, and Vimal Sharma.
Bugs: ATLAS-1659
https://issues.apache.org/jira/browse/ATLAS-1659
Repository: atlas
Description
-------
Currently the remapping is not done when the trait/tag gets added/removed from entity. This patch fixes it.
Diffs
-----
repository/src/main/java/org/apache/atlas/repository/graph/FullTextMapperV2.java e029c399
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityChangeNotifier.java 41674fe6
Diff: https://reviews.apache.org/r/57434/diff/1/
Testing
-------
mvn clean install works
Was able to see the updated fullText field using gremlin after performing add/delete tags from UI
Thanks,
Apoorv Naik
Re: Review Request 57434: ATLAS-1659: Full text changes when tags are
added/removed
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57434/#review168374
-----------------------------------------------------------
repository/src/main/java/org/apache/atlas/repository/graph/FullTextMapperV2.java
Lines 79 (patched)
<https://reviews.apache.org/r/57434/#comment240584>
since this map() method computes & returns index-text for the given classifications only (and not for the entire entity), consider renaming to getIndexTextForClassifications()
repository/src/main/java/org/apache/atlas/repository/graph/FullTextMapperV2.java
Lines 104 (patched)
<https://reviews.apache.org/r/57434/#comment240585>
Consider renaming map() to getIndexTextForEntity()
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityChangeNotifier.java
Lines 222 (patched)
<https://reviews.apache.org/r/57434/#comment240586>
Consider renaming this method to updateFullTextMapping()
- Madhan Neethiraj
On March 8, 2017, 10:10 p.m., Apoorv Naik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57434/
> -----------------------------------------------------------
>
> (Updated March 8, 2017, 10:10 p.m.)
>
>
> Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Sarath Subramanian, Suma Shivaprasad, and Vimal Sharma.
>
>
> Bugs: ATLAS-1659
> https://issues.apache.org/jira/browse/ATLAS-1659
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Currently the remapping is not done when the trait/tag gets added/removed from entity. This patch fixes it.
>
>
> Diffs
> -----
>
> repository/src/main/java/org/apache/atlas/repository/graph/FullTextMapperV2.java e029c399
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityChangeNotifier.java 41674fe6
>
>
> Diff: https://reviews.apache.org/r/57434/diff/1/
>
>
> Testing
> -------
>
> mvn clean install works
> Was able to see the updated fullText field using gremlin after performing add/delete tags from UI
>
>
> Thanks,
>
> Apoorv Naik
>
>
Re: Review Request 57434: ATLAS-1659: Full text changes when tags are
added/removed
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57434/#review169079
-----------------------------------------------------------
Ship it!
Ship It!
- Madhan Neethiraj
On March 15, 2017, 9:48 p.m., Apoorv Naik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57434/
> -----------------------------------------------------------
>
> (Updated March 15, 2017, 9:48 p.m.)
>
>
> Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Sarath Subramanian, Suma Shivaprasad, and Vimal Sharma.
>
>
> Bugs: ATLAS-1659
> https://issues.apache.org/jira/browse/ATLAS-1659
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Currently the remapping is not done when the trait/tag gets added/removed from entity. This patch fixes it.
>
>
> Diffs
> -----
>
> repository/src/main/java/org/apache/atlas/repository/graph/FullTextMapperV2.java e029c399
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityChangeNotifier.java 41674fe6
>
>
> Diff: https://reviews.apache.org/r/57434/diff/2/
>
>
> Testing
> -------
>
> mvn clean install works
> Was able to see the updated fullText field using gremlin after performing add/delete tags from UI
>
>
> Thanks,
>
> Apoorv Naik
>
>
Re: Review Request 57434: ATLAS-1659: Full text changes when tags are
added/removed
Posted by Apoorv Naik <na...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57434/
-----------------------------------------------------------
(Updated March 15, 2017, 9:48 p.m.)
Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Sarath Subramanian, Suma Shivaprasad, and Vimal Sharma.
Bugs: ATLAS-1659
https://issues.apache.org/jira/browse/ATLAS-1659
Repository: atlas
Description
-------
Currently the remapping is not done when the trait/tag gets added/removed from entity. This patch fixes it.
Diffs (updated)
-----
repository/src/main/java/org/apache/atlas/repository/graph/FullTextMapperV2.java e029c399
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityChangeNotifier.java 41674fe6
Diff: https://reviews.apache.org/r/57434/diff/2/
Changes: https://reviews.apache.org/r/57434/diff/1-2/
Testing
-------
mvn clean install works
Was able to see the updated fullText field using gremlin after performing add/delete tags from UI
Thanks,
Apoorv Naik