You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@poi.apache.org by on...@apache.org on 2015/11/24 02:08:34 UTC
svn commit: r1716003 -
/poi/trunk/src/ooxml/java/org/apache/poi/xssf/usermodel/XSSFSheet.java
Author: onealj
Date: Tue Nov 24 01:08:34 2015
New Revision: 1716003
URL: http://svn.apache.org/viewvc?rev=1716003&view=rev
Log:
remove duplicate null check of srcStartRow (identified by FindBugs)
Modified:
poi/trunk/src/ooxml/java/org/apache/poi/xssf/usermodel/XSSFSheet.java
Modified: poi/trunk/src/ooxml/java/org/apache/poi/xssf/usermodel/XSSFSheet.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/ooxml/java/org/apache/poi/xssf/usermodel/XSSFSheet.java?rev=1716003&r1=1716002&r2=1716003&view=diff
==============================================================================
--- poi/trunk/src/ooxml/java/org/apache/poi/xssf/usermodel/XSSFSheet.java (original)
+++ poi/trunk/src/ooxml/java/org/apache/poi/xssf/usermodel/XSSFSheet.java Tue Nov 24 01:08:34 2015
@@ -2699,9 +2699,8 @@ public class XSSFSheet extends POIXMLDoc
for (int index=1; index < srcRows.size(); index++) {
final Row prevRow = srcRows.get(index-1);
final Row curRow = srcRows.get(index);
- if (prevRow == null || curRow == null) {
- throw new IllegalArgumentException("srcRows may not contain null rows. Found null row at index " +
- index + " after Row " + prevRow.getRowNum() + ".");
+ if (curRow == null) {
+ throw new IllegalArgumentException("srcRows may not contain null rows. Found null row at index " + index + ".");
//} else if (curRow.getRowNum() != prevRow.getRowNum() + 1) {
// throw new IllegalArgumentException("srcRows must contain continuously increasing row numbers. " +
// "Got srcRows[" + (index-1) + "]=Row " + prevRow.getRowNum() + ", srcRows[" + index + "]=Row " + curRow.getRowNum() + ".");
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@poi.apache.org
For additional commands, e-mail: commits-help@poi.apache.org