You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@trafficserver.apache.org by ma...@apache.org on 2017/12/06 07:55:50 UTC

[trafficserver] branch quic-latest updated (8e8e57d -> f0c333c)

This is an automated email from the ASF dual-hosted git repository.

maskit pushed a change to branch quic-latest
in repository https://gitbox.apache.org/repos/asf/trafficserver.git.


    from 8e8e57d  Use std::atomic for packet counts in LossDetector
     new 76083d8  Fix loss detection timer
     new f0c333c  Fix a bug introduced with a300d3a828916ce1ec8b6bf5ee818ce4a327bc28

The 2 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:
 iocore/net/quic/QUICLossDetector.cc |  6 +++++-
 iocore/net/quic/QUICLossDetector.h  | 22 +++++++++++-----------
 2 files changed, 16 insertions(+), 12 deletions(-)

-- 
To stop receiving notification emails like this one, please contact
['"commits@trafficserver.apache.org" <co...@trafficserver.apache.org>'].

[trafficserver] 02/02: Fix a bug introduced with a300d3a828916ce1ec8b6bf5ee818ce4a327bc28

Posted by ma...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

maskit pushed a commit to branch quic-latest
in repository https://gitbox.apache.org/repos/asf/trafficserver.git

commit f0c333cec0aefb1421cfa5e24ba8e1a4f8a703eb
Author: Masakazu Kitajo <ma...@apache.org>
AuthorDate: Wed Dec 6 16:54:47 2017 +0900

    Fix a bug introduced with a300d3a828916ce1ec8b6bf5ee818ce4a327bc28
---
 iocore/net/quic/QUICLossDetector.h | 22 +++++++++++-----------
 1 file changed, 11 insertions(+), 11 deletions(-)

diff --git a/iocore/net/quic/QUICLossDetector.h b/iocore/net/quic/QUICLossDetector.h
index 64702a9..b7071fc 100644
--- a/iocore/net/quic/QUICLossDetector.h
+++ b/iocore/net/quic/QUICLossDetector.h
@@ -76,17 +76,17 @@ private:
   ink_hrtime _DEFAULT_INITIAL_RTT  = HRTIME_MSECONDS(100);
 
   // 3.2.2.  Variables of interest
-  Action *_loss_detection_alarm      = nullptr;
-  uint32_t _handshake_count          = 0;
-  uint32_t _tlp_count                = 0;
-  uint32_t _rto_count                = 0;
-  uint32_t _largest_sent_before_rto  = 0;
-  uint32_t _largest_sent_packet      = 0;
-  uint32_t _largest_acked_packet     = 0;
-  uint32_t _time_of_last_sent_packet = 0;
-  ink_hrtime _latest_rtt             = 0;
-  ink_hrtime _smoothed_rtt           = 0;
-  ink_hrtime _rttvar                 = 0;
+  Action *_loss_detection_alarm        = nullptr;
+  uint32_t _handshake_count            = 0;
+  uint32_t _tlp_count                  = 0;
+  uint32_t _rto_count                  = 0;
+  uint32_t _largest_sent_before_rto    = 0;
+  uint32_t _largest_sent_packet        = 0;
+  uint32_t _largest_acked_packet       = 0;
+  ink_hrtime _time_of_last_sent_packet = 0;
+  ink_hrtime _latest_rtt               = 0;
+  ink_hrtime _smoothed_rtt             = 0;
+  ink_hrtime _rttvar                   = 0;
   uint32_t _reordering_threshold;
   double _time_reordering_fraction;
   ink_hrtime _loss_time = 0;

-- 
To stop receiving notification emails like this one, please contact
"commits@trafficserver.apache.org" <co...@trafficserver.apache.org>.

[trafficserver] 01/02: Fix loss detection timer

Posted by ma...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

maskit pushed a commit to branch quic-latest
in repository https://gitbox.apache.org/repos/asf/trafficserver.git

commit 76083d8bf0acdffe2faaacbd429a5712e970919e
Author: Masakazu Kitajo <ma...@apache.org>
AuthorDate: Wed Dec 6 16:17:50 2017 +0900

    Fix loss detection timer
---
 iocore/net/quic/QUICLossDetector.cc | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/iocore/net/quic/QUICLossDetector.cc b/iocore/net/quic/QUICLossDetector.cc
index b32aab2..4a58690 100644
--- a/iocore/net/quic/QUICLossDetector.cc
+++ b/iocore/net/quic/QUICLossDetector.cc
@@ -336,7 +336,11 @@ QUICLossDetector::_set_loss_detection_alarm()
     QUICLDDebug("RTO alarm will be set");
   }
 
-  this->_loss_detection_alarm_at = Thread::get_hrtime() + alarm_duration;
+  if (this->_loss_detection_alarm_at) {
+    this->_loss_detection_alarm_at = std::min(this->_loss_detection_alarm_at, Thread::get_hrtime() + alarm_duration);
+  } else {
+    this->_loss_detection_alarm_at = Thread::get_hrtime() + alarm_duration;
+  }
   QUICLDDebug("Loss detection alarm has been set to %" PRId64, alarm_duration);
 
   if (!this->_loss_detection_alarm) {

-- 
To stop receiving notification emails like this one, please contact
"commits@trafficserver.apache.org" <co...@trafficserver.apache.org>.