You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by GitBox <gi...@apache.org> on 2022/04/27 12:31:21 UTC

[GitHub] [incubator-seatunnel] ruanwenjun commented on a diff in pull request #1758: [Bug][Connector]fix runtime errors of webhook connector

ruanwenjun commented on code in PR #1758:
URL: https://github.com/apache/incubator-seatunnel/pull/1758#discussion_r859740108


##########
seatunnel-connectors/seatunnel-connectors-spark/seatunnel-connector-spark-webhook/src/main/scala/org/apache/seatunnel/spark/webhook/source/HttpData.scala:
##########
@@ -17,12 +17,12 @@
 
 package org.apache.seatunnel.spark.webhook.source
 
-import java.util.Date
+import java.sql.Timestamp
 
 /**
  * Streaming data read from local server will have this schema
  *
  * @param value - The payload POSTed to http endpoint.
  * @param timestamp - Timestamp of when it was put on a stream.
  */
-case class HttpData(value: String, timestamp: Date)
+case class HttpData(value: String, timestamp: Timestamp)

Review Comment:
   I think use `long` type it better, there is no need to transform to `Timestamp` here.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org