You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/02/16 20:33:34 UTC

[GitHub] [incubator-tvm] zhiics opened a new pull request #4897: [Realy][fix] Fix alpha_equal bug for attribute check

zhiics opened a new pull request #4897: [Realy][fix] Fix alpha_equal bug for attribute check
URL: https://github.com/apache/incubator-tvm/pull/4897
 
 
   This PR fix a bug in alpha_equal for attribute checking where it mistakenly uses lhs as the rhs.
   
   The discussion is here: https://discuss.tvm.ai/t/relay-analysis-alpha-equal-questions-and-potential-issues/5704/2
   
   This is the problem 1 in the discussion. Need a separate PR for Problem2.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-tvm] zhiics commented on issue #4897: [Realy][fix] Fix alpha_equal bug for attribute check

Posted by GitBox <gi...@apache.org>.
zhiics commented on issue #4897: [Realy][fix] Fix alpha_equal bug for attribute check
URL: https://github.com/apache/incubator-tvm/pull/4897#issuecomment-586749999
 
 
   CC @tqchen @icemelon9 @jroesch @MarisaKirisame  @soiferj @mbarrett97 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-tvm] tqchen commented on issue #4897: [Realy][fix] Fix alpha_equal bug for attribute check

Posted by GitBox <gi...@apache.org>.
tqchen commented on issue #4897: [Realy][fix] Fix alpha_equal bug for attribute check
URL: https://github.com/apache/incubator-tvm/pull/4897#issuecomment-586784597
 
 
   Thanks @zhiics !

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-tvm] tqchen merged pull request #4897: [Realy][fix] Fix alpha_equal bug for attribute check

Posted by GitBox <gi...@apache.org>.
tqchen merged pull request #4897: [Realy][fix] Fix alpha_equal bug for attribute check
URL: https://github.com/apache/incubator-tvm/pull/4897
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services