[GitHub] [ignite-3] agura commented on a diff in pull request #1451: IGNITE-18413 Reorganize metastorage modules

[GitBox <gi...@apache.org>]

agura commented on code in PR #1451:
URL: https://github.com/apache/ignite-3/pull/1451#discussion_r1050237885


##########
modules/metastorage-api/src/main/java/org/apache/ignite/internal/metastorage/dsl/OperationType.java:
##########
@@ -15,7 +15,7 @@
  * limitations under the License.
  */
 
-package org.apache.ignite.internal.metastorage.common;
+package org.apache.ignite.internal.metastorage.dsl;

Review Comment:
   I really don't like the `dsl` name. There is still a difference between a language and an API. Really minor, but I can't be silent :)



##########
modules/metastorage-api/src/main/java/org/apache/ignite/internal/metastorage/MetaStorageManager.java:
##########
@@ -0,0 +1,125 @@
+/*

Review Comment:
   What is a difference between `MetaStorageManager` and `MetaStorageService`? Also we have some conventions about a naming and what I see from this interface is a service rather than a manager.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org