[GitHub] [kafka] rajinisivaram commented on a change in pull request #9495: KAFKA-10642: Expose the real stack trace if any exception occurred during SSL Client Trust Verification in extension

[GitBox <gi...@apache.org>]

rajinisivaram commented on a change in pull request #9495:
URL: https://github.com/apache/kafka/pull/9495#discussion_r545172648



##########
File path: clients/src/main/java/org/apache/kafka/common/security/ssl/SslFactory.java
##########
@@ -95,6 +95,7 @@ public void configure(Map<String, ?> configs) throws KafkaException {
             try {
                 SslEngineValidator.validate(builder, builder);
             } catch (Exception e) {
+                log.error("SSLFactory configure failed during validate", e);
                 throw new ConfigException("A client SSLEngine created with the provided settings " +

Review comment:
       We should probably change the exception class here since `ConfigException` takes a config name and value while this one is passing in the exception message and cause like other exception constructors. Then existing log entry would be sufficient as well.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org