You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Chun-Hung Hsiao <ch...@apache.org> on 2018/08/21 18:30:20 UTC

Review Request 68445: Marked HDFS image fetching as experimental.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68445/
-----------------------------------------------------------

Review request for mesos and Gilbert Song.


Bugs: MESOS-8794
    https://issues.apache.org/jira/browse/MESOS-8794


Repository: mesos


Description
-------

Marked HDFS image fetching as experimental.


Diffs
-----

  docs/configuration/agent.md bcddea2f8606f71fc46a39debca323d85c1d94c1 
  docs/container-image.md 7342f23f0ac3270668d459f0c337cc86aac7c5a6 
  src/slave/flags.cpp fd208f64416ae865b81c8ba5950b20bde6be00a3 


Diff: https://reviews.apache.org/r/68445/diff/1/


Testing
-------

`make`


Thanks,

Chun-Hung Hsiao


Re: Review Request 68445: Marked HDFS image fetching as experimental.

Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68445/#review207713
-----------------------------------------------------------



PASS: Mesos patch 68445 was successfully built and tested.

Reviews applied: `['68445']`

All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2209/mesos-review-68445

- Mesos Reviewbot Windows


On Aug. 21, 2018, 10:01 p.m., Chun-Hung Hsiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68445/
> -----------------------------------------------------------
> 
> (Updated Aug. 21, 2018, 10:01 p.m.)
> 
> 
> Review request for mesos and Gilbert Song.
> 
> 
> Bugs: MESOS-8794
>     https://issues.apache.org/jira/browse/MESOS-8794
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Marked HDFS image fetching as experimental.
> 
> 
> Diffs
> -----
> 
>   docs/configuration/agent.md bcddea2f8606f71fc46a39debca323d85c1d94c1 
>   docs/container-image.md 7342f23f0ac3270668d459f0c337cc86aac7c5a6 
>   src/slave/flags.cpp fd208f64416ae865b81c8ba5950b20bde6be00a3 
> 
> 
> Diff: https://reviews.apache.org/r/68445/diff/2/
> 
> 
> Testing
> -------
> 
> `make`
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>


Re: Review Request 68445: Marked HDFS image fetching as experimental.

Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68445/#review207706
-----------------------------------------------------------


Fix it, then Ship it!





docs/container-image.md
Line 229 (original), 229 (patched)
<https://reviews.apache.org/r/68445/#comment291210>

    s/point/points/g


- Gilbert Song


On Aug. 21, 2018, 3:01 p.m., Chun-Hung Hsiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68445/
> -----------------------------------------------------------
> 
> (Updated Aug. 21, 2018, 3:01 p.m.)
> 
> 
> Review request for mesos and Gilbert Song.
> 
> 
> Bugs: MESOS-8794
>     https://issues.apache.org/jira/browse/MESOS-8794
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Marked HDFS image fetching as experimental.
> 
> 
> Diffs
> -----
> 
>   docs/configuration/agent.md bcddea2f8606f71fc46a39debca323d85c1d94c1 
>   docs/container-image.md 7342f23f0ac3270668d459f0c337cc86aac7c5a6 
>   src/slave/flags.cpp fd208f64416ae865b81c8ba5950b20bde6be00a3 
> 
> 
> Diff: https://reviews.apache.org/r/68445/diff/2/
> 
> 
> Testing
> -------
> 
> `make`
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>


Re: Review Request 68445: Marked HDFS image fetching as experimental.

Posted by Chun-Hung Hsiao <ch...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68445/
-----------------------------------------------------------

(Updated Aug. 21, 2018, 10:01 p.m.)


Review request for mesos and Gilbert Song.


Changes
-------

Added a missing word.


Bugs: MESOS-8794
    https://issues.apache.org/jira/browse/MESOS-8794


Repository: mesos


Description
-------

Marked HDFS image fetching as experimental.


Diffs (updated)
-----

  docs/configuration/agent.md bcddea2f8606f71fc46a39debca323d85c1d94c1 
  docs/container-image.md 7342f23f0ac3270668d459f0c337cc86aac7c5a6 
  src/slave/flags.cpp fd208f64416ae865b81c8ba5950b20bde6be00a3 


Diff: https://reviews.apache.org/r/68445/diff/2/

Changes: https://reviews.apache.org/r/68445/diff/1-2/


Testing
-------

`make`


Thanks,

Chun-Hung Hsiao


Re: Review Request 68445: Marked HDFS image fetching as experimental.

Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68445/#review207689
-----------------------------------------------------------



PASS: Mesos patch 68445 was successfully built and tested.

Reviews applied: `['68445']`

All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2206/mesos-review-68445

- Mesos Reviewbot Windows


On Aug. 21, 2018, 6:30 p.m., Chun-Hung Hsiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68445/
> -----------------------------------------------------------
> 
> (Updated Aug. 21, 2018, 6:30 p.m.)
> 
> 
> Review request for mesos and Gilbert Song.
> 
> 
> Bugs: MESOS-8794
>     https://issues.apache.org/jira/browse/MESOS-8794
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Marked HDFS image fetching as experimental.
> 
> 
> Diffs
> -----
> 
>   docs/configuration/agent.md bcddea2f8606f71fc46a39debca323d85c1d94c1 
>   docs/container-image.md 7342f23f0ac3270668d459f0c337cc86aac7c5a6 
>   src/slave/flags.cpp fd208f64416ae865b81c8ba5950b20bde6be00a3 
> 
> 
> Diff: https://reviews.apache.org/r/68445/diff/1/
> 
> 
> Testing
> -------
> 
> `make`
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>