You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "aloyszhang (via GitHub)" <gi...@apache.org> on 2023/08/17 14:33:41 UTC
[GitHub] [pulsar] aloyszhang opened a new issue, #21016: [Bug] UniformLoadShedder selects wrong overloadbroker and underloadbroker
aloyszhang opened a new issue, #21016:
URL: https://github.com/apache/pulsar/issues/21016
### Search before asking
- [X] I searched in the [issues](https://github.com/apache/pulsar/issues) and found nothing similar.
### Version
master branch
### Minimal reproduce step
1. start some brokers whose LoadSheddingStrategy is UniformLoadShedder
2. make sure each of them has a different load like
- broker0 with msgRate 50000 and throughput 50 MB
- broker1 with msgRate 60000 and throughput 60 MB
- broker2 with msgRate 70000 and throughput 70 MB
- broker3 with msgRate 10000 and throughput 80 MB
- broker4 with msgRate 20000 and throughput 10 MB
3. then UniformLoadShedder will select the wrong overload broker and underload broker for bundle unloading
### What did you expect to see?
broker2 should be selected as the overloaded broker since it has the highest msgRate and msgThroughtput
### What did you see instead?
broker 4 may be selected as the overload broker
### Anything else?
The root cause is here https://github.com/apache/pulsar/blob/c890a8c15cd9d30518818377c3155776514f5a9c/pulsar-broker/src/main/java/org/apache/pulsar/broker/loadbalance/impl/UniformLoadShedder.java#L72-L86
the update condition for the overload broker is ` if (msgRate > maxMsgRate.getValue() || throughputRate > maxThroughputRate.getValue()) `, which will update overload broker ethier msgRate > maxMsgRate or the throughputRate >maxThroughputRate.
if brokers' load is
- broker0 with msgRate 50000 and throughput 50 MB
- broker1 with msgRate 60000 and throughput 60 MB
- broker2 with msgRate 70000 and throughput 70 MB
- broker3 with msgRate 10000 and throughput 80 MB
- broker4 with msgRate 20000 and throughput 10 MB
then the broker4 will be selected as the overloaded broker
### Are you willing to submit a PR?
- [X] I'm willing to submit a PR!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] aloyszhang commented on issue #21016: [Bug] UniformLoadShedder selects wrong overloadbroker and underloadbroker
Posted by "aloyszhang (via GitHub)" <gi...@apache.org>.
aloyszhang commented on issue #21016:
URL: https://github.com/apache/pulsar/issues/21016#issuecomment-1683483580
after discuss with @lordcheng10, will close #19890 and cerate a new pr #21025 fot this issue
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] BewareMyPower closed issue #21016: [Bug] UniformLoadShedder selects wrong overloadbroker and underloadbroker
Posted by "BewareMyPower (via GitHub)" <gi...@apache.org>.
BewareMyPower closed issue #21016: [Bug] UniformLoadShedder selects wrong overloadbroker and underloadbroker
URL: https://github.com/apache/pulsar/issues/21016
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org