You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@dolphinscheduler.apache.org by Jiajie Zhong <zh...@hotmail.com> on 2021/10/09 01:30:55 UTC

Re: [PROPOSAL][Code style] Remove Intellij IDEA code style

FYI, we just merged related PRs to our main repo[1] and doc repo[2].
And this thread has been done.

[1]: https://github.com/apache/dolphinscheduler/pull/6432 <https://github.com/apache/dolphinscheduler/pull/6432>
[2]: https://github.com/apache/dolphinscheduler-website/pull/449 <https://github.com/apache/dolphinscheduler-website/pull/449>
Best Wish
— Jiajie

> On Sep 30, 2021, at 20:37, Jiajie Zhong <zh...@hotmail.com> wrote:
> 
> Hi guys,
> 
>     When I create a PR in our repo, I found out CI code style failed even though
> I format the code in my IDEA. I know that we have two code style checker and
> some rule of them are not compatible when I create an issue[1] in github. I think
> it’s better to keep single code style rule, it easy for developer and make our code
> style consistency.
> 
>     I proposal remove the Intellij IDEA code style, due to our CI code style using
> reviewdog  with `checkstyle` output. And I already submit a PR[2] of it.
> 
> 
> [1]: https://github.com/apache/dolphinscheduler/issues/6428 <https://github.com/apache/dolphinscheduler/issues/6428>
> [2]: https://github.com/apache/dolphinscheduler/pull/6432 <https://github.com/apache/dolphinscheduler/pull/6432>
> 
> Best Wish
> — Jiajie
>