You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2022/08/29 12:34:14 UTC

[GitHub] [ignite] J-Bakuli opened a new pull request, #10220: IGNITE-17541 Add set prefix to sendServerExceptionStackTraceToClient(…

J-Bakuli opened a new pull request, #10220:
URL: https://github.com/apache/ignite/pull/10220

   …) in ThinClientConfiguration.
   
   The method name doesn't allow to set up this option in XML configuration, because Spring expects 'set' prefix for setters.
   https://github.com/apache/ignite/blob/4a6ff6f4aa1994b39bf40cc8ad80ac5df704d569/modules/core/src/main/java/org/apache/ignite/configuration/ThinClientConfiguration.java#L107
   
   Possible workarounds:
   1) Add extra ThinClientConfiguration bean with necessary parameters
   
   2) Set up thinClientConfiguration by means of SpEL
   
   Although there several ways out of the situation it is more convenient to set up this property directly and use 'set' and 'get' prefixes to setter and getter methods thus I have added 'set' prefix to the sendServerExceptionStackTraceToClient() below:
   1. ThinClientConfiguration.class
   https://github.com/apache/ignite/blob/4a6ff6f4aa1994b39bf40cc8ad80ac5df704d569/modules/core/src/main/java/org/apache/ignite/configuration/ThinClientConfiguration.java#L107
   
   2. PlatformConfigurationUtils.class in readClientConnectorConfiguration()
   https://github.com/apache/ignite/blob/4a6ff6f4aa1994b39bf40cc8ad80ac5df704d569/modules/core/src/main/java/org/apache/ignite/internal/processors/platform/utils/PlatformConfigurationUtils.java#L1963
   
   Thank you for submitting the pull request to the Apache Ignite.
   
   In order to streamline the review of the contribution 
   we ask you to ensure the following steps have been taken:
   
   ### The Contribution Checklist
   - [ ] There is a single JIRA ticket related to the pull request. 
   - [ ] The web-link to the pull request is attached to the JIRA ticket.
   - [ ] The JIRA ticket has the _Patch Available_ state.
   - [ ] The pull request body describes changes that have been made. 
   The description explains _WHAT_ and _WHY_ was made instead of _HOW_.
   - [ ] The pull request title is treated as the final commit message. 
   The following pattern must be used: `IGNITE-XXXX Change summary` where `XXXX` - number of JIRA issue.
   - [ ] A reviewer has been mentioned through the JIRA comments 
   (see [the Maintainers list](https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute#HowtoContribute-ReviewProcessandMaintainers)) 
   - [ ] The pull request has been checked by the Teamcity Bot and 
   the `green visa` attached to the JIRA ticket (see [TC.Bot: Check PR](https://mtcga.gridgain.com/prs.html))
   
   ### Notes
   - [How to Contribute](https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute)
   - [Coding abbreviation rules](https://cwiki.apache.org/confluence/display/IGNITE/Abbreviation+Rules)
   - [Coding Guidelines](https://cwiki.apache.org/confluence/display/IGNITE/Coding+Guidelines)
   - [Apache Ignite Teamcity Bot](https://cwiki.apache.org/confluence/display/IGNITE/Apache+Ignite+Teamcity+Bot)
   
   If you need any help, please email dev@ignite.apache.org or ask anу advice on http://asf.slack.com _#ignite_ channel.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [ignite] J-Bakuli closed pull request #10220: IGNITE-17541 Add set prefix to sendServerExceptionStackTraceToClient(…

Posted by GitBox <gi...@apache.org>.
J-Bakuli closed pull request #10220: IGNITE-17541 Add set prefix to sendServerExceptionStackTraceToClient(…
URL: https://github.com/apache/ignite/pull/10220


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [ignite] ivandasch commented on pull request #10220: IGNITE-17541 Add set prefix to sendServerExceptionStackTraceToClient(…

Posted by GitBox <gi...@apache.org>.
ivandasch commented on PR #10220:
URL: https://github.com/apache/ignite/pull/10220#issuecomment-1231667863

   @J-Bakuli Unfortunately, it is impossible just to rename the method's name. Because this action breaks backward compatibility.
   So it is required to introduce a new getter and setter and deprecated the old ones.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org