You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2021/11/24 13:42:54 UTC

[GitHub] [camel-k] lburgazzoli commented on a change in pull request #2780: fix(lint): net/http.Get must not be called (noctx)

lburgazzoli commented on a change in pull request #2780:
URL: https://github.com/apache/camel-k/pull/2780#discussion_r756087797



##########
File path: pkg/cmd/util_content_test.go
##########
@@ -97,3 +98,12 @@ func TestIsBinary(t *testing.T) {
 	assert.True(t, isBinary("application/zip"))
 	assert.False(t, isBinary("text/plain"))
 }
+
+func TestContentHttp(t *testing.T) {
+	u, err := url.Parse("https://raw.githubusercontent.com/apache/camel-k/main/go.mod")

Review comment:
       to test this, I had to call a remote service that may sometimes fail
   is this acceptable ?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org