[GitHub] [arrow] jorisvandenbossche commented on pull request #36701: GH-35289: [Python] Support large variable width types in numpy conversion

["jorisvandenbossche (via GitHub)" <gi...@apache.org>]

jorisvandenbossche commented on PR #36701:
URL: https://github.com/apache/arrow/pull/36701#issuecomment-1687818153

   > If there's a way to consolidate the common code let me know, this is my first C++ in a long time.
   
   In the Visit functions, I think the main (only?) difference is the type of `builder` that was created? In that case I _think_ it should be possible to template this: have a single `VisitString()` that is templated on the builder type, and then the `Visit(const StringType& type)` could be a small wrapper around calling `VisitString<ChunkedStringBuilder>()`. Although the builder having different parameters to instantiate it might complicate things ..


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org