You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by markgrover <gi...@git.apache.org> on 2016/07/15 17:59:59 UTC
[GitHub] spark pull request #14223: [SPARK-10614][CORE] SystemClock uses non-monotoni...
GitHub user markgrover opened a pull request:
https://github.com/apache/spark/pull/14223
[SPARK-10614][CORE] SystemClock uses non-monotonic time
## What changes were proposed in this pull request?
Change SystemClock to derive time from System.nanoTime() instead of System.currentTimeMillis(). This is because using System.currentTimeMillis() makes waitTillTime() routine brittle against systems like VMs where time can go forward and backwards.
Shout out to @steveloughran for doing a good chunk of research and a previous PR (#8766) on this in 2015.
## How was this patch tested?
Build is green, I am running unit tests, they are looking green, but are also taking a while. So, filing this PR a little proactively.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/markgrover/spark SPARK-10614
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/14223.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #14223
----
commit a475cd82455e892b23efe2e8fad0dade2ec8b043
Author: Mark Grover <ma...@apache.org>
Date: 2016-07-14T23:42:39Z
[SPARK-10614][CORE] SystemClock uses non-monotonic time in its wait logic
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #14223: [SPARK-10614][CORE] SystemClock uses non-monotonic time
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14223
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #14223: [SPARK-10614][CORE] SystemClock uses non-monotoni...
Posted by markgrover <gi...@git.apache.org>.
Github user markgrover commented on a diff in the pull request:
https://github.com/apache/spark/pull/14223#discussion_r71030596
--- Diff: core/src/main/scala/org/apache/spark/util/Clock.scala ---
@@ -33,18 +40,18 @@ private[spark] class SystemClock extends Clock {
val minPollTime = 25L
/**
- * @return the same time (milliseconds since the epoch)
- * as is reported by `System.currentTimeMillis()`
+ * @return the same time in milliseconds as is derived from `System.nanoTime()`
*/
- def getTimeMillis(): Long = System.currentTimeMillis()
+ def getTimeMillis(): Long = System.nanoTime() / (1000 * 1000)
--- End diff --
Will do
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #14223: [SPARK-10614][CORE] Change SystemClock to derive time fr...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14223
**[Test build #62399 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62399/consoleFull)** for PR 14223 at commit [`3dec78a`](https://github.com/apache/spark/commit/3dec78a28147588ce7d88eb4e5790265af8ca28b).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #14223: [SPARK-10614][CORE] Change SystemClock to derive time fr...
Posted by vanzin <gi...@git.apache.org>.
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/14223
@markgrover these two tests fail consistently just on your PR, so it looks like they're not as unrelated as you thought.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #14223: [SPARK-10614][CORE] Change SystemClock to derive time fr...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14223
**[Test build #62421 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62421/consoleFull)** for PR 14223 at commit [`3dec78a`](https://github.com/apache/spark/commit/3dec78a28147588ce7d88eb4e5790265af8ca28b).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #14223: [SPARK-10614][CORE] Change SystemClock to derive time fr...
Posted by markgrover <gi...@git.apache.org>.
Github user markgrover commented on the issue:
https://github.com/apache/spark/pull/14223
The unit test failures from the previous run looked unrelated, fyi.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #14223: [SPARK-10614][CORE] SystemClock uses non-monotonic time
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14223
**[Test build #62383 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62383/consoleFull)** for PR 14223 at commit [`a475cd8`](https://github.com/apache/spark/commit/a475cd82455e892b23efe2e8fad0dade2ec8b043).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #14223: [SPARK-10614][CORE] SystemClock uses non-monotoni...
Posted by markgrover <gi...@git.apache.org>.
Github user markgrover commented on a diff in the pull request:
https://github.com/apache/spark/pull/14223#discussion_r71030586
--- Diff: core/src/main/scala/org/apache/spark/util/Clock.scala ---
@@ -21,7 +21,14 @@ package org.apache.spark.util
* An interface to represent clocks, so that they can be mocked out in unit tests.
*/
private[spark] trait Clock {
+ /** @return the time in milliseconds */
def getTimeMillis(): Long
+
+ /**
+ * Wait until a clock's view of current time reaches the specified target time.
+ * @param targetTime block until the current time is at least this value
--- End diff --
Will do
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #14223: [SPARK-10614][CORE] Change SystemClock to derive ...
Posted by rxin <gi...@git.apache.org>.
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/14223#discussion_r71071394
--- Diff: core/src/main/scala/org/apache/spark/util/Clock.scala ---
@@ -17,11 +17,21 @@
package org.apache.spark.util
+import java.util.concurrent.TimeUnit
+
/**
* An interface to represent clocks, so that they can be mocked out in unit tests.
*/
private[spark] trait Clock {
+ /** @return the time in milliseconds */
def getTimeMillis(): Long
+
+ /**
+ * Wait until a clock's view of current time reaches the specified target time.
+ *
+ * @param targetTime block until the current time is at least this value
+ * @return clock's view of current time when the wait has completed
+ */
def waitTillTime(targetTime: Long): Long
--- End diff --
what's the unit?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #14223: [SPARK-10614][CORE] Change SystemClock to derive time fr...
Posted by markgrover <gi...@git.apache.org>.
Github user markgrover commented on the issue:
https://github.com/apache/spark/pull/14223
Thanks @vanzin Yeah, I noticed that too. Will take a look.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #14223: [SPARK-10614][CORE] Change SystemClock to derive time fr...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14223
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62395/
Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #14223: [SPARK-10614][CORE] SystemClock uses non-monotoni...
Posted by vanzin <gi...@git.apache.org>.
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/14223#discussion_r71024004
--- Diff: core/src/main/scala/org/apache/spark/util/Clock.scala ---
@@ -21,7 +21,14 @@ package org.apache.spark.util
* An interface to represent clocks, so that they can be mocked out in unit tests.
*/
private[spark] trait Clock {
+ /** @return the time in milliseconds */
def getTimeMillis(): Long
+
+ /**
+ * Wait until a clock's view of current time reaches the specified target time.
+ * @param targetTime block until the current time is at least this value
--- End diff --
nit: blank line before argument list
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #14223: [SPARK-10614][CORE] Change SystemClock to derive time fr...
Posted by markgrover <gi...@git.apache.org>.
Github user markgrover commented on the issue:
https://github.com/apache/spark/pull/14223
And, thanks for your feedback, @rxin, I will take a look.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #14223: [SPARK-10614][CORE] Change SystemClock to derive time fr...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14223
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62399/
Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #14223: [SPARK-10614][CORE] Change SystemClock to derive time fr...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14223
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62421/
Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #14223: [SPARK-10614][CORE] Change SystemClock to derive time fr...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14223
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #14223: [SPARK-10614][CORE] SystemClock uses non-monotoni...
Posted by vanzin <gi...@git.apache.org>.
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/14223#discussion_r71024094
--- Diff: core/src/main/scala/org/apache/spark/util/Clock.scala ---
@@ -33,18 +40,18 @@ private[spark] class SystemClock extends Clock {
val minPollTime = 25L
/**
- * @return the same time (milliseconds since the epoch)
- * as is reported by `System.currentTimeMillis()`
+ * @return the same time in milliseconds as is derived from `System.nanoTime()`
*/
- def getTimeMillis(): Long = System.currentTimeMillis()
+ def getTimeMillis(): Long = System.nanoTime() / (1000 * 1000)
--- End diff --
`TimeUnit.NANOSECONDS.toMillis(...)`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #14223: [SPARK-10614][CORE] Change SystemClock to derive time fr...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14223
**[Test build #62399 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62399/consoleFull)** for PR 14223 at commit [`3dec78a`](https://github.com/apache/spark/commit/3dec78a28147588ce7d88eb4e5790265af8ca28b).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #14223: [SPARK-10614][CORE] Change SystemClock to derive time fr...
Posted by vanzin <gi...@git.apache.org>.
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/14223
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #14223: [SPARK-10614][CORE] SystemClock uses non-monotonic time
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14223
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62383/
Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #14223: [SPARK-10614][CORE] Change SystemClock to derive time fr...
Posted by vanzin <gi...@git.apache.org>.
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/14223
I don't think closing this PR is the right thing to do. This solves an actual problem, in that we have code that depends on the clock being monotonic, but a non-monotonic clock is being used.
If there's a need to differentiate that from actual system time, then perhaps we need to extend the `Clock` API. But there's an actual issue that this change is fixing.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #14223: [SPARK-10614][CORE] Change SystemClock to derive time fr...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14223
**[Test build #62421 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62421/consoleFull)** for PR 14223 at commit [`3dec78a`](https://github.com/apache/spark/commit/3dec78a28147588ce7d88eb4e5790265af8ca28b).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #14223: [SPARK-10614][CORE] Change SystemClock to derive ...
Posted by rxin <gi...@git.apache.org>.
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/14223#discussion_r71071399
--- Diff: core/src/main/scala/org/apache/spark/util/Clock.scala ---
@@ -17,11 +17,21 @@
package org.apache.spark.util
+import java.util.concurrent.TimeUnit
+
/**
* An interface to represent clocks, so that they can be mocked out in unit tests.
*/
private[spark] trait Clock {
+ /** @return the time in milliseconds */
def getTimeMillis(): Long
+
+ /**
+ * Wait until a clock's view of current time reaches the specified target time.
+ *
+ * @param targetTime block until the current time is at least this value
+ * @return clock's view of current time when the wait has completed
+ */
def waitTillTime(targetTime: Long): Long
--- End diff --
it'd be good to rename the variable to reflect the unit, similar to getTimeMillis
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #14223: [SPARK-10614][CORE] Change SystemClock to derive time fr...
Posted by zsxwing <gi...@git.apache.org>.
Github user zsxwing commented on the issue:
https://github.com/apache/spark/pull/14223
> This method can only be used to measure elapsed time and is not related to any other notion of system or wall-clock time. The value returned represents nanoseconds since some fixed but arbitrary origin time (perhaps in the future, so values may be negative). The same origin is used by all invocations of this method in an instance of a Java virtual machine; other virtual machine instances are likely to use a different origin.
As per javadoc, `System.nanoTime` cannot be used to get the current system time. I saw most of places just use `getTimeMillis` to get the current system time and display it on UI. I don't think we can change it to `System.nanoTime`.
@markgrover could you close this pr, please?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #14223: [SPARK-10614][CORE] Change SystemClock to derive time fr...
Posted by vanzin <gi...@git.apache.org>.
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/14223
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #14223: [SPARK-10614][CORE] Change SystemClock to derive time fr...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14223
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #14223: [SPARK-10614][CORE] SystemClock uses non-monotonic time
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14223
**[Test build #62383 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62383/consoleFull)** for PR 14223 at commit [`a475cd8`](https://github.com/apache/spark/commit/a475cd82455e892b23efe2e8fad0dade2ec8b043).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #14223: [SPARK-10614][CORE] Change SystemClock to derive time fr...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14223
**[Test build #62395 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62395/consoleFull)** for PR 14223 at commit [`3dec78a`](https://github.com/apache/spark/commit/3dec78a28147588ce7d88eb4e5790265af8ca28b).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #14223: [SPARK-10614][CORE] Change SystemClock to derive time fr...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14223
**[Test build #62395 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62395/consoleFull)** for PR 14223 at commit [`3dec78a`](https://github.com/apache/spark/commit/3dec78a28147588ce7d88eb4e5790265af8ca28b).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #14223: [SPARK-10614][CORE] SystemClock uses non-monotonic time
Posted by vanzin <gi...@git.apache.org>.
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/14223
Can you change the PR title to reflect the actual change, and not the bug's title?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #14223: [SPARK-10614][CORE] Change SystemClock to derive time fr...
Posted by zsxwing <gi...@git.apache.org>.
Github user zsxwing commented on the issue:
https://github.com/apache/spark/pull/14223
@vanzin I didn't mean closing the JIRA ticket. Let's just close this stale PR since it doesn't have the correct fix. We can always submit a new PR if necessary.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #14223: [SPARK-10614][CORE] Change SystemClock to derive time fr...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14223
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #14223: [SPARK-10614][CORE] Change SystemClock to derive ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/14223
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org