You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ignite.apache.org by Sergey Kozlov <sk...@gridgain.com> on 2016/06/20 13:23:51 UTC
HTTP Rest API: increment/decrement or append/prepend are candidates
to deprecate?
Hi Igniters
I've reviewed the API <http://apacheignite.gridgain.org/docs/rest-api> for
HTTP Rest provided by Ignite and have a question: do we really need some
commands which cover the particular cases of value type like
increment/decrement (value is integer) or append/prepend (value is string).
Moreover last pair of commands actually don't work (ticket
<https://issues.apache.org/jira/browse/IGNITE-945> has been filed by me a
year ago!).
Such commands helps to test Rest but they're away from real use cases.
I suppose they could be marked as deprecated for 1.7 and removed for 1.8.
Any such operation should be implemented via SQL level.
Thoughts?
--
Sergey Kozlov
GridGain Systems
www.gridgain.com
Re: HTTP Rest API: increment/decrement or append/prepend are
candidates to deprecate?
Posted by Saikat Maitra <sa...@gmail.com>.
Hello
I have raised a PR [1] for this ticket [2].
Please review and let me know if any change is required.
Regards
Saikat
[1] https://github.com/apache/ignite/pull/847
[2] https://issues.apache.org/jira/browse/IGNITE-945
On Tue, Jun 28, 2016 at 6:13 AM, Valentin Kulichenko <
valentin.kulichenko@gmail.com> wrote:
> As far as I know, these commands come from Memcache protocol. Since we
> claim that we're Memcache-compatible, we can't just remove them. But we
> definitely should fix the ticket :)
>
> -Val
>
> On Tue, Jun 21, 2016 at 6:21 AM, Saikat Maitra <sa...@gmail.com>
> wrote:
>
> > Sure Dmitriy
> >
> > I can pick it up.
> >
> > Regards
> > Saikat
> >
> > On Tue, Jun 21, 2016 at 6:34 AM, Dmitriy Setrakyan <
> dsetrakyan@apache.org>
> > wrote:
> >
> > > I personally think we should not remove these commands, unless they
> > become
> > > really painful to maintain.
> > >
> > > Igniters, anyone in the community wants to pick up IGNITE-945
> > > <https://issues.apache.org/jira/browse/IGNITE-945>? Does not look
> like a
> > > complicated fix.
> > >
> > > Thanks,
> > > D.
> > >
> > > On Mon, Jun 20, 2016 at 6:23 AM, Sergey Kozlov <sk...@gridgain.com>
> > > wrote:
> > >
> > > > Hi Igniters
> > > >
> > > > I've reviewed the API <
> http://apacheignite.gridgain.org/docs/rest-api>
> > > for
> > > > HTTP Rest provided by Ignite and have a question: do we really need
> > some
> > > > commands which cover the particular cases of value type like
> > > > increment/decrement (value is integer) or append/prepend (value is
> > > string).
> > > > Moreover last pair of commands actually don't work (ticket
> > > > <https://issues.apache.org/jira/browse/IGNITE-945> has been filed by
> > me
> > > a
> > > > year ago!).
> > > > Such commands helps to test Rest but they're away from real use
> cases.
> > > >
> > > > I suppose they could be marked as deprecated for 1.7 and removed for
> > 1.8.
> > > > Any such operation should be implemented via SQL level.
> > > >
> > > > Thoughts?
> > > >
> > > > --
> > > > Sergey Kozlov
> > > > GridGain Systems
> > > > www.gridgain.com
> > > >
> > >
> >
>
Re: HTTP Rest API: increment/decrement or append/prepend are
candidates to deprecate?
Posted by Valentin Kulichenko <va...@gmail.com>.
As far as I know, these commands come from Memcache protocol. Since we
claim that we're Memcache-compatible, we can't just remove them. But we
definitely should fix the ticket :)
-Val
On Tue, Jun 21, 2016 at 6:21 AM, Saikat Maitra <sa...@gmail.com>
wrote:
> Sure Dmitriy
>
> I can pick it up.
>
> Regards
> Saikat
>
> On Tue, Jun 21, 2016 at 6:34 AM, Dmitriy Setrakyan <ds...@apache.org>
> wrote:
>
> > I personally think we should not remove these commands, unless they
> become
> > really painful to maintain.
> >
> > Igniters, anyone in the community wants to pick up IGNITE-945
> > <https://issues.apache.org/jira/browse/IGNITE-945>? Does not look like a
> > complicated fix.
> >
> > Thanks,
> > D.
> >
> > On Mon, Jun 20, 2016 at 6:23 AM, Sergey Kozlov <sk...@gridgain.com>
> > wrote:
> >
> > > Hi Igniters
> > >
> > > I've reviewed the API <http://apacheignite.gridgain.org/docs/rest-api>
> > for
> > > HTTP Rest provided by Ignite and have a question: do we really need
> some
> > > commands which cover the particular cases of value type like
> > > increment/decrement (value is integer) or append/prepend (value is
> > string).
> > > Moreover last pair of commands actually don't work (ticket
> > > <https://issues.apache.org/jira/browse/IGNITE-945> has been filed by
> me
> > a
> > > year ago!).
> > > Such commands helps to test Rest but they're away from real use cases.
> > >
> > > I suppose they could be marked as deprecated for 1.7 and removed for
> 1.8.
> > > Any such operation should be implemented via SQL level.
> > >
> > > Thoughts?
> > >
> > > --
> > > Sergey Kozlov
> > > GridGain Systems
> > > www.gridgain.com
> > >
> >
>
Re: HTTP Rest API: increment/decrement or append/prepend are
candidates to deprecate?
Posted by Saikat Maitra <sa...@gmail.com>.
Sure Dmitriy
I can pick it up.
Regards
Saikat
On Tue, Jun 21, 2016 at 6:34 AM, Dmitriy Setrakyan <ds...@apache.org>
wrote:
> I personally think we should not remove these commands, unless they become
> really painful to maintain.
>
> Igniters, anyone in the community wants to pick up IGNITE-945
> <https://issues.apache.org/jira/browse/IGNITE-945>? Does not look like a
> complicated fix.
>
> Thanks,
> D.
>
> On Mon, Jun 20, 2016 at 6:23 AM, Sergey Kozlov <sk...@gridgain.com>
> wrote:
>
> > Hi Igniters
> >
> > I've reviewed the API <http://apacheignite.gridgain.org/docs/rest-api>
> for
> > HTTP Rest provided by Ignite and have a question: do we really need some
> > commands which cover the particular cases of value type like
> > increment/decrement (value is integer) or append/prepend (value is
> string).
> > Moreover last pair of commands actually don't work (ticket
> > <https://issues.apache.org/jira/browse/IGNITE-945> has been filed by me
> a
> > year ago!).
> > Such commands helps to test Rest but they're away from real use cases.
> >
> > I suppose they could be marked as deprecated for 1.7 and removed for 1.8.
> > Any such operation should be implemented via SQL level.
> >
> > Thoughts?
> >
> > --
> > Sergey Kozlov
> > GridGain Systems
> > www.gridgain.com
> >
>
Re: HTTP Rest API: increment/decrement or append/prepend are
candidates to deprecate?
Posted by Dmitriy Setrakyan <ds...@apache.org>.
I personally think we should not remove these commands, unless they become
really painful to maintain.
Igniters, anyone in the community wants to pick up IGNITE-945
<https://issues.apache.org/jira/browse/IGNITE-945>? Does not look like a
complicated fix.
Thanks,
D.
On Mon, Jun 20, 2016 at 6:23 AM, Sergey Kozlov <sk...@gridgain.com> wrote:
> Hi Igniters
>
> I've reviewed the API <http://apacheignite.gridgain.org/docs/rest-api> for
> HTTP Rest provided by Ignite and have a question: do we really need some
> commands which cover the particular cases of value type like
> increment/decrement (value is integer) or append/prepend (value is string).
> Moreover last pair of commands actually don't work (ticket
> <https://issues.apache.org/jira/browse/IGNITE-945> has been filed by me a
> year ago!).
> Such commands helps to test Rest but they're away from real use cases.
>
> I suppose they could be marked as deprecated for 1.7 and removed for 1.8.
> Any such operation should be implemented via SQL level.
>
> Thoughts?
>
> --
> Sergey Kozlov
> GridGain Systems
> www.gridgain.com
>