You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/09/18 02:44:34 UTC

[GitHub] [pulsar] thomasleplus opened a new pull request #12081: this prefix required

thomasleplus opened a new pull request #12081:
URL: https://github.com/apache/pulsar/pull/12081


   This line was actually assigning the method argument to itself instead of setting the static field of the same name.
   
   
   ### Motivation
   
   Fix a simple mistake.
   
   ### Modifications
   
   Trivial change.
   
   ### Verifying this change
   
   - [x] Make sure that the change passes the CI checks.
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   ### Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API: no
     - The schema: no
     - The default values of configurations: no
     - The wire protocol: no
     - The rest endpoints: no
     - The admin cli options: no
     - Anything that affects deployment: no
   
   ### Documentation
   
   Check the box below and label this PR (if you have committer privilege).
   
   Need to update docs? 
   
   - [ ] doc-required 
   - [x] no-need-doc 
   - [ ] doc 
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] thomasleplus commented on pull request #12081: this prefix required

Posted by GitBox <gi...@apache.org>.
thomasleplus commented on pull request #12081:
URL: https://github.com/apache/pulsar/pull/12081#issuecomment-922168598


   Wrong fix, will submit another PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] thomasleplus closed pull request #12081: this prefix required

Posted by GitBox <gi...@apache.org>.
thomasleplus closed pull request #12081:
URL: https://github.com/apache/pulsar/pull/12081


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org